ScanPolarity to wizard and to raw data overview as quick control #1840
Conversation
|
Done from my side. |
We can validate the parameters before triggering the task and show a message box if polarity "ANY" was chosen for polarity switching data. The message should also point the user to polarity scan filter option |
|
Not sure its usually multiple tasks running in parallel - so we would need to have a mechanism to only show one dialog. I will create a new issue for this. |
| polarityCombo = new ComboBox<>(FXCollections.observableList( | ||
| List.of(WizardMsPolarity.No_filter, WizardMsPolarity.Positive, WizardMsPolarity.Negative))); |
There was a problem hiding this comment.
use string converter -> any -> no filter
There was a problem hiding this comment.
using PolarityType now and made a PolarityFilterComboBox to hide the StringConverter No filter is now Any polarity
|
|
||
| import io.github.mzmine.datamodel.PolarityType; | ||
|
|
||
| public enum WizardMsPolarity { |
There was a problem hiding this comment.
make package private to wizard package
There was a problem hiding this comment.
problem is that it is being used by the parameters and the builders that are in different subpackages. So cannot be package private
There was a problem hiding this comment.
at least now its only used in wizard
|
All done |
No description provided.