Update rt normalization #1947
Merged
Update rt normalization #1947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteffenHeu
reviewed
Jul 8, 2024
Member
SteffenHeu
left a comment
There was a problem hiding this comment.
Looks good, pelase sort the feature lists by descending number of features first
.../main/java/io/github/mzmine/modules/dataprocessing/norm_rtcalibration/RTCalibrationTask.java
Show resolved
Hide resolved
.../main/java/io/github/mzmine/modules/dataprocessing/norm_rtcalibration/RTCalibrationTask.java
Outdated
Show resolved
Hide resolved
.../main/java/io/github/mzmine/modules/dataprocessing/norm_rtcalibration/RTCalibrationTask.java
Show resolved
Hide resolved
Comment on lines
259
to
260
| float correctedRt = (float) (normalizedRT - originalRT); | ||
| normalizedFeature.set(RtAbsoluteCorrectionType.class, correctedRt); |
Member
There was a problem hiding this comment.
please add this to the javadoc of the RtAbsoluteCorrectionType, so it's always calculated in the same way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized rt normalization:
Documentation update: open PR