Adjust local min edges #1977
Merged
Adjust local min edges #1977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinschmid
previously approved these changes
Jul 29, 2024
Member
robinschmid
left a comment
There was a problem hiding this comment.
Looks good. It changes the outcome but I think the results are better this way
|
|
||
| resolved.add(Range.closed(x[currentRegionStart], x[currentRegionEnd])); | ||
| int start; | ||
| if(y[currentRegionStart] != 0 && y[Math.max(currentRegionStart - 1, 0)] == 0.0) { |
Member
There was a problem hiding this comment.
seems fine to me.
Maybe add a comment here why we are doing this to preserve the idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add 1 data point on each side if the flanking data point is zero (after filtering for chromatographic threshold)