FileDownloadTask and parameter to download external assets #1986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteffenHeu
reviewed
Jul 25, 2024
Member
SteffenHeu
left a comment
There was a problem hiding this comment.
Looks nice, got some questions/comments
mzmine-community/src/main/java/io/github/mzmine/modules/io/download/DownloadAssets.java
Outdated
Show resolved
Hide resolved
| * Fixed details on external assets. See also {@link DownloadAsset} to define new downloads. | ||
| */ | ||
| public enum ExternalAsset { | ||
| ThermoRawFileParser, MSCONVERT, |
Member
There was a problem hiding this comment.
maybe add a tag if we are allowed to download it? If not, only show the website icon and open the page and maybe open the folder where the asset should be saved?
Member
There was a problem hiding this comment.
or a dialog for the downloads folder, then we can still do the extraction and move the files to the correct location
Member
Author
There was a problem hiding this comment.
So far getDownloadAssets() will just return an empty list. So there will be no options to download and this will only show a button that leads to the website of the tool
mzmine-community/src/main/java/io/github/mzmine/modules/io/download/FileDownloadTask.java
Outdated
Show resolved
Hide resolved
mzmine-community/src/main/java/io/github/mzmine/modules/io/download/FileDownloader.java
Outdated
Show resolved
Hide resolved
...ty/src/main/java/io/github/mzmine/parameters/parametertypes/filenames/FileNameComponent.java
Outdated
Show resolved
Hide resolved
…ad-task # Conflicts: # mzmine-community/src/main/java/io/github/mzmine/parameters/parametertypes/filenames/FileNameComponent.java # utils/src/main/java/io/github/mzmine/util/files/ExtensionFilters.java # utils/src/main/java/io/github/mzmine/util/files/FileAndPathUtil.java
Member
Author
|
Addressed all comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a FileDownloadTask that downloads DownloadAsset that are defined as ExternalAsset.
Also adds a new parameter that allows asset download or manual selection:
I added two examples to the DemoParameters (quick accessL PreDemo Module)