Analyze log files #2481
Merged
Analyze log files #2481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteffenHeu
reviewed
Mar 21, 2025
| logState = LogFileState.RUN_BATCH; | ||
|
|
||
| } else if (logState == LogFileState.RUN_BATCH && lowerMessage.startsWith( | ||
| "processing of task batch step") && lowerMessage.endsWith("finished")) { |
Member
There was a problem hiding this comment.
is processing of task batch step correct? i cannot find it in my logs.
Member
Author
There was a problem hiding this comment.
2025-03-20 13:24:30 INFO io.github.mzmine.taskcontrol.impl.WrappedTask run Processing of task Batch step 24/24 done, status FINISHED
SteffenHeu
reviewed
Mar 21, 2025
...unity/src/main/java/io/github/mzmine/modules/tools/output_compare_csv/CheckResultWriter.java
Outdated
Show resolved
Hide resolved
SteffenHeu
reviewed
Mar 21, 2025
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class AnalyzeLogFileTaskTest { |
Member
There was a problem hiding this comment.
Test does not cover going out of the batch mode into manual again
Member
Author
There was a problem hiding this comment.
good call I will add a full log file as a resource.
I added the state tracking later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module to analyze log files - can filter out warnings and errors