More filters in wizard #2775
Merged
More filters in wizard #2775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
test for metadata failing |
56787a2 to
0df5a5a
Compare
SteffenHeu
previously approved these changes
Jul 30, 2025
Member
SteffenHeu
left a comment
There was a problem hiding this comment.
some recommendations for paraphrasing the errors
.../src/main/java/io/github/mzmine/modules/tools/batchwizard/BatchWizardCreateBatchChecker.java
Outdated
Show resolved
Hide resolved
|
|
||
| // qc issue | ||
| errors.add( | ||
| "No QC samples found in the filenames or metadata file. Add _qc to the filename or define the metadata column=%s and value=%s".formatted( |
Member
There was a problem hiding this comment.
i think the formatting would be easier to read if it was
column %s with value %s
and then use StringUtils.inQuotes
Member
Author
There was a problem hiding this comment.
Changed and used """ text block to just use " in the string
No QC samples found in the filenames or metadata file. Add _qc to the filename or define the metadata column as "%s" with value "%s".
.../src/main/java/io/github/mzmine/modules/tools/batchwizard/BatchWizardCreateBatchChecker.java
Outdated
Show resolved
Hide resolved
2e3aff5 to
ea7fd82
Compare
1cf4c23 to
f807a38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RowsFilterParameters.createDefaultAllOff();method to put it closer to the actual parameters