ims: refactor frame ms2 info addition #2927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinschmid
reviewed
Oct 22, 2025
| @Override | ||
| public Set<IonMobilityMsMsInfo> getImsMsMsInfos() { | ||
| return precursorInfos; | ||
| return Set.copyOf(precursorInfos); |
Member
There was a problem hiding this comment.
I think a good option istead of the copy is to use an unmodifiable wrapper that avoids the copy. Only issue might be modification exceptions in case multiple threads try to add/read the content.
Collections.unmodifiableSet
So both works for me. I feel like this method does not need to provide multi threading secure implementation of the collection.
And it may be called a lot to get the precursor mz etc.
robinschmid
previously approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msms infos were added through an exposed hash set. refactored and added a method to add the msms infos, made the exposed hash set unmodifiable