Freeform 2D canvas layout for workspace panes - #5987

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Packages/CmuxSettings/Sources/CmuxSettings/Values/ShortcutAction.swift`:
- Around line 355-366: The new canvas shortcut labels (cases like
toggleCanvasLayout, canvasRevealFocusedPane, canvasOverview, canvasTidy,
canvasAlignLeft, canvasAlignRight, canvasAlignTop, canvasAlignBottom,
canvasEqualizeWidths, canvasEqualizeHeights, canvasDistributeHorizontally,
canvasDistributeVertically in ShortcutAction) are hardcoded English strings;
replace each return value with a localized lookup (e.g., use String(localized:
"SHORTCUT_<IDENTIFIER>", defaultValue: "…", comment: "…") or your project’s
localization API) and add corresponding keys and translations to
Resources/Localizable.xcstrings for all supported locales so every new
user-facing label is localized.

In `@Sources/AppDelegate.swift`:
- Around line 13557-13568: The canvas shortcut display names are missing
localization keys; add string-catalog entries for each canvas action key named
like shortcutAction.toggleCanvasLayout, shortcutAction.canvasRevealFocusedPane,
shortcutAction.canvasOverview, shortcutAction.canvasTidy,
shortcutAction.canvasAlignLeft, shortcutAction.canvasAlignRight,
shortcutAction.canvasAlignTop, shortcutAction.canvasAlignBottom,
shortcutAction.canvasEqualizeWidths, shortcutAction.canvasEqualizeHeights,
shortcutAction.canvasDistributeHorizontally, and
shortcutAction.canvasDistributeVertically in Resources/Localizable.xcstrings
(use an English defaultValue for each), and ensure the same keys are present in
every supported locale so UI code that looks up names for
KeyboardShortcutSettings.Action.canvasActions / matchConfiguredShortcut and
CanvasActionExecutor(canvasAction: ...) will find localized strings.

In `@Sources/Canvas/CanvasDocumentView.swift`:
- Around line 34-59: The grid start-position calculation in draw(_:) is
overcomplicated: replace the phase and manual floor+while-adjust logic that
computes x and y starts (currently using canvasToDocumentOffset,
Self.gridSpacing, Self.gridDotRadius and the while x < dirtyRect.minX / while y
< dirtyRect.minY adjustments) with direct startX/startY computations using the
given phaseX/phaseY and spacing (compute the first grid coordinate via rounding
up the division then multiplying by spacing and adding phase), remove the extra
while loops that bump the start into the rect, and keep the existing nested
loops that advance by spacing and draw the dots.

In `@Sources/Canvas/CanvasPaneContent.swift`:
- Around line 52-53: The terminal visibility lifecycle is inverted and
asymmetric: change the occlusion call in the rendering mapping to use the
inverse (e.g., hostedView.setOcclusion(!rendering) or setOcclusion(isOccluded)
where isOccluded = !rendering) so rendering==true means not occluded, and add
symmetric teardown to restore UI visibility by calling
hostedView.setVisibleInUI(false) on unmount/teardown (mirror the existing
hostedView.setVisibleInUI(true) on mount). Also ensure visibility transitions
explicitly pass through a hide-state (call setVisibleInUI(false) before changing
occlusion/visibility) to preserve scroll/visibility behavior; update the
handlers referenced (hostedView.setVisibleInUI, hostedView.setOcclusion, and the
mount/unmount/teardown block that installs hostedView.setFocusHandler)
accordingly.

In `@Sources/Canvas/ContentView`+CanvasCommandPalette.swift:
- Around line 22-39: The command-palette shows hard-coded English because canvas
action titles are returned as plain literals and the subtitle is missing the km
locale; update ShortcutAction.label to return localized strings (use
String(localized:) or NSLocalizedString) for all canvas-related cases
(toggleCanvasLayout, canvasRevealFocusedPane, canvasOverview, canvasTidy, and
all align/equalize/distribute variants) and ensure
commandPaletteCanvasCommandContributions() continues to use command.action.label
(now localized); also add the "command.canvas.subtitle" translation to the km
locale in Resources/Localizable.xcstrings so the subtitle resolves for that
locale.

In `@Sources/KeyboardShortcutSettings.swift`:
- Around line 244-255: Add Khmer ("km") translations for the new canvas shortcut
labels by updating Resources/Localizable.xcstrings to include entries for each
localization key used in KeyboardShortcutSettings
(shortcut.toggleCanvasLayout.label, shortcut.canvasRevealFocusedPane.label,
shortcut.canvasOverview.label, shortcut.canvasTidy.label,
shortcut.canvasAlignLeft.label, shortcut.canvasAlignRight.label,
shortcut.canvasAlignTop.label, shortcut.canvasAlignBottom.label,
shortcut.canvasEqualizeWidths.label, shortcut.canvasEqualizeHeights.label,
shortcut.canvasDistributeHorizontally.label,
shortcut.canvasDistributeVertically.label), providing appropriate Khmer strings
for each key so the km locale mirrors the existing default/other locales.

In `@Sources/TerminalController`+ControlCanvasContext.swift:
- Around line 95-111: controlCanvasReveal currently returns
.paneNotFound(UUID()) when both surfaceID and ws.focusedPanelId are nil,
producing a spurious random UUID; add a new resolution case (e.g.,
.noTargetSpecified) to ControlCanvasActionResolution and return that from
controlCanvasReveal when the target cannot be resolved (inside the guard let
target ... else branch), then update any downstream handling/serialization of
ControlCanvasActionResolution to recognize the new .noTargetSpecified case (also
adjust any protocol/wire mapping or tests that assert on paneNotFound behavior).

In `@Sources/Workspace.swift`:
- Around line 16911-16914: The test suite never exercises the canvas-specific
branch because Workspace.layoutMode defaults to .splits; add a unit test in
WorkspaceUnitTests that sets workspace.layoutMode = .canvas (use
WorkspaceLayoutMode.canvas), then call workspace.moveFocus(...) with the same
direction used in existing tests and assert the expected canvas-focus change (or
spy that moveCanvasFocus(direction:) on the Workspace is invoked) to cover the
early-return routing to moveCanvasFocus; reference the public API moveFocus, the
internal moveCanvasFocus method, and the layoutMode property when implementing
the test.

In `@Sources/WorkspaceContentView.swift`:
- Around line 359-372: The canvas branch is skipping the lifecycle/effect
modifiers that are currently attached only to bonsplitView; move the shared
.onAppear/.onChange/.onReceive/.onDisappear (and any other workspace lifecycle
side-effect modifiers) from bonsplitView up to the enclosing Group (or its
parent wrapper) so both WorkspaceCanvasHostView and bonsplitView execute the
same hooks; keep the existing .ignoresSafeArea(...) call and its
isMinimalMode/isFullScreen conditional, and ensure the moved modifiers still
reference workspace, appearance, isWorkspaceVisible, isWorkspaceInputActive, and
workspacePortalPriority as needed.

In `@web/data/cmux-shortcuts.ts`:
- Around line 180-190: The new shortcut category in web/data/cmux-shortcuts.ts
uses titleKey: "canvas" and blurbKey: "canvasBlurb" but those i18n keys are only
present in en.json and ja.json; add docs.keyboardShortcuts.cat.canvas and
docs.keyboardShortcuts.cat.canvasBlurb entries to all missing locale files (de,
fr, es, ko, zh-CN, zh-TW, pt-BR, ru, it, pl, uk, tr, da, no) with appropriate
translated strings (or fallback English strings) so every locale contains the
same keys referenced by the Canvas category.

In `@web/messages/ja.json`:
- Around line 997-998: Add the missing localization keys "canvas" and
"canvasBlurb" to every locale JSON listed in web/i18n/routing.ts so all
supported locales match the en/ja set; locate each locale file under
web/messages/ (e.g., the other .json files beside ja.json), add the two keys
with appropriate translations (or temporary English fallbacks) mirroring the
meaning in ja.json, and ensure the keys are valid JSON and placed consistently
with nearby UI strings to keep parity across locales.

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@cmux.xcodeproj/project.pbxproj`:
- Around line 4271-4274: The XCSwiftPackageProductDependency entry for
CA53A005CA53A005CA53A005 (productName = CmuxCanvasUI) is missing its required
package pointer; update that block to include a package = <PACKAGE_REF_ID> /*
<PackageName> */; entry that points to the corresponding XCSwiftPackageReference
used elsewhere in the project (find the XCSwiftPackageReference whose
products/include CmuxCanvasUI or whose comment matches the package), so the
XCSwiftPackageProductDependency for CmuxCanvasUI correctly references the
package ID.

---

Outside diff comments:
In `@Packages/CmuxCanvasUI/Sources/CmuxCanvasUI/CanvasModel.swift`:
- Around line 54-62: The loop over panelIds rebuilds layout.panes.map(\.frame)
for every new pane causing repeated full scans; compute the avoiding frames once
before the loop (e.g., let avoidingFrames = layout.panes.map(\.frame)) and use
that when calling placer.frameForNewPane, then when you successfully create a
new pane append its frame to the avoidingFrames collection so subsequent
iterations avoid rescanning layout.panes; update references: the for panelId in
panelIds where !layout.contains(...), placer.frameForNewPane(size:
Self.defaultPaneSize, near: anchor, avoiding: ...), and ensure
focusedPanelId/layout.frame(of:) logic remains unchanged while using the cached
avoidingFrames.

---

Duplicate comments:
In `@Sources/Canvas/CanvasPaneContent.swift`:
- Around line 81-98: Invert the occlusion polarity in setRendering(_ rendering:
Bool) by calling panel.surface.setOcclusion(!rendering) so that rendering ==
true => not occluded, and in unmount() restore the terminal's UI-visible state
symmetrically by calling hostedView.setVisibleInUI(false) before tearing down
(after hostedView.setFocusHandler(nil) and before
hostedView.removeFromSuperview()); keep the existing
panel.surface.setOcclusion(true) call or change it to match the inverted
polarity if needed so occlusion and visible flags remain consistent.

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Sources/TerminalController`+ControlCanvasContext.swift:
- Around line 134-141: Update the switch on the direction string so only
recognized values mutate state: add an explicit case "reset" that calls
executor.perform(.zoomReset) and handle unknown values by returning a non-OK
resolution (do not call executor.perform). Keep the existing cases for "in" ->
.zoomIn and "out" -> .zoomOut, reference the direction variable and
executor.perform(.zoomIn/.zoomOut/.zoomReset) when making the changes, and
ensure the code returns a failure/non-OK result for the default branch instead
of silently resetting.