iOS: unified animated toast system (CmuxMobileToast) - #8376

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Packages/iOS/CmuxMobileToast/Sources/CmuxMobileToast/ToastGalleryView.swift (1)

99-190: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Propagate task cancellation to prevent instantaneous demo execution.

By using try? to swallow the CancellationError from clock.sleep, the pause function will return immediately if the .task is cancelled (e.g., if the user dismisses the view). This causes the remainder of the autodemo script to execute instantaneously, spamming the ToastCenter queue in a single frame.

Make pause, runAutodemoIfRequested, and recordPassthroughProbe throwing functions, and use try await so that cancellation properly aborts the sequence. Note that you will also need to update the caller (e.g., .task { try? await runAutodemoIfRequested() }) which is outside of this diff block.

🐛 Proposed fix

-    private func runAutodemoIfRequested() async {
+    private func runAutodemoIfRequested() async throws {
         guard ProcessInfo.processInfo.environment["CMUX_TOAST_GALLERY_AUTORUN"] == "1" else { return }
         let clock = ContinuousClock()
-        func pause(_ seconds: Double) async {
-            try? await clock.sleep(for: .seconds(seconds))
+        func pause(_ seconds: Double) async throws {
+            try await clock.sleep(for: .seconds(seconds))
         }
 
-        await pause(2)
+        try await pause(2)
         `#if` os(iOS)
-        await recordPassthroughProbe(pause: pause)
+        try await recordPassthroughProbe(pause: pause)
         `#endif`
         toasts.present(.success("Workspace created"))
-        await pause(5.5)
+        try await pause(5.5)
 
         toasts.present(.failure(
             "Not connected to your Mac.",
             title: "Couldn't rename workspace",
             coalescingKey: "demo.error"
         ))
-        await pause(2)
+        try await pause(2)
         toasts.present(.failure(
             "Not connected to your Mac.",
             title: "Couldn't rename workspace",
             coalescingKey: "demo.error"
         ))
-        await pause(7.5)
+        try await pause(7.5)
 
         toasts.present(.success("First: workspace created"))
         toasts.present(.info("Second: agent finished"))
         toasts.present(.warning("Third: build is out of date"))
-        await pause(13)
+        try await pause(13)
 
         toasts.present(.info("Copied to clipboard", systemImage: "doc.on.doc"))
-        await pause(4.5)
+        try await pause(4.5)
         toasts.present(.success("Saved", placement: .bottom))
-        await pause(5)
+        try await pause(5)
 
         toasts.present(.failure(
             "The request timed out.",
             title: "Couldn't create workspace",
             action: Toast.Action(label: "Retry") {}
         ))
-        await pause(7.5)
+        try await pause(7.5)
         toasts.dismissAll()
     }
 
     `#if` os(iOS)
     /// Exercises the passthrough window's `hitTest` with real on-device
     /// geometry and writes the verdicts to Documents/toast-probe.txt: with no
     /// toast the overlay must return nil everywhere (UIKit then routes the
     /// touch to the app's window below); with a toast visible, the card region
     /// must resolve to a live view while the rest still falls through.
-    private func recordPassthroughProbe(pause: (Double) async -> Void) async {
+    private func recordPassthroughProbe(pause: (Double) async throws -> Void) async throws {
         var lines: [String] = []
         defer {
             let url = URL.documentsDirectory.appending(path: "toast-probe.txt")
             try? lines.joined(separator: "\n").write(to: url, atomically: true, encoding: .utf8)
         }
         guard let overlay = UIApplication.shared.connectedScenes
             .compactMap({ $0 as? UIWindowScene })
             .flatMap(\.windows)
             .first(where: { $0 is ToastPassthroughWindow }) else {
             lines.append("FAIL overlay window not found")
             return
         }
         let center = CGPoint(x: overlay.bounds.midX, y: overlay.bounds.midY)
         let empty = overlay.hitTest(center, with: nil)
         lines.append(empty == nil
             ? "PASS empty overlay passes touches through (hitTest nil)"
             : "FAIL empty overlay captured touch: \(type(of: empty!))")
 
         toasts.present(.info("Passthrough probe", coalescingKey: "probe"))
-        await pause(0.8)
+        try await pause(0.8)
         lines.append("presented=\(String(describing: toasts.presented?.toast.message)) safeTop=\(overlay.safeAreaInsets.top)")
         var hitAny = false
         for y in stride(from: 4, through: 120, by: 8) {
             let point = CGPoint(x: overlay.bounds.midX, y: overlay.safeAreaInsets.top + CGFloat(y))
             if let hit = overlay.hitTest(point, with: nil) {
                 hitAny = true
                 lines.append("hit y=+\(y): \(type(of: hit))")
             }
         }
         lines.append(hitAny
             ? "PASS toast region captures touch"
             : "FAIL toast region did not hit-test at any scanned point")
         let besideToast = overlay.hitTest(center, with: nil)
         lines.append(besideToast == nil
             ? "PASS area beside visible toast still passes through"
             : "FAIL area beside toast captured: \(type(of: besideToast!))")
         toasts.dismissAll()
-        await pause(0.8)
+        try await pause(0.8)
     }
     `#endif`

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Packages/iOS/CmuxMobileToast/Sources/CmuxMobileToast/ToastGalleryView.swift`
around lines 99 - 190, Propagate cancellation through the autodemo flow: make
runAutodemoIfRequested, its local pause helper, and recordPassthroughProbe
throwing, and replace swallowed sleep calls with try await. Update the task
caller to handle the thrown cancellation (for example, by using try?), while
preserving the existing demo sequence and probe behavior when not cancelled.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes