Skip to content

Allow HTTP in built-in browser for local dev hosts - #206

Merged
lawrencecchen merged 8 commits into
mainfrom
issue-180-http-nonsecure-hosts
Feb 20, 2026
Merged

Allow HTTP in built-in browser for local dev hosts#206
lawrencecchen merged 8 commits into
mainfrom
issue-180-http-nonsecure-hosts

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add NSAppTransportSecurity with NSAllowsArbitraryLoadsInWebContent=true in Resources/Info.plist so WKWebView can load non-HTTPS local/dev URLs
  • add a regression unit test that asserts the ATS web-content override is present

Validation

  • xcodebuild -project GhosttyTabs.xcodeproj -scheme cmux -configuration Debug -destination 'platform=macOS' build ✅
  • xcodebuild -project GhosttyTabs.xcodeproj -scheme cmux-unit -configuration Debug -destination 'platform=macOS' -only-testing:cmuxTests/AppTransportSecurityTests test ❌ fails due pre-existing compile errors in cmuxTests/CmuxWebViewKeyEquivalentTests.swift (UpdateChannelSettings not found), unrelated to this change
  • ./scripts/reload.sh --tag issue-180-http-nonsecure-hosts ✅

Closes #180

@lawrencecchen
Allow HTTP loads in built-in web content
9c52373 
Fixes #180 by enabling NSAllowsArbitraryLoadsInWebContent for WKWebView and adding a regression test that asserts ATS web-content override exists in Resources/Info.plist.
@cmux-agent

cmux-agent Bot commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
Older manaflow preview screenshots (latest comment is below)

Preview Videos and Screenshots

Open Workspace (1 hr expiry) · Open Dev Browser (1 hr expiry) · Open Diff Heatmap

Screenshot capture was skipped.

No UI changes detected - screenshots skipped

Generated by manaflow preview system

@vercel

vercel Bot commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cmux Ready Ready Preview, Comment Feb 20, 2026 11:30pm

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Feb 20, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9c52373141

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Resources/Info.plist
@cmux-agent

cmux-agent Bot commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
Older manaflow preview screenshots (latest comment is below)

Preview Videos and Screenshots

Open Workspace (1 hr expiry) · Open Dev Browser (1 hr expiry) · Open Diff Heatmap

Failed to capture screenshots for commit 821e3ab.

Claude Code native binary not found at /root/.bun/bin/claude. Please ensure Claude Code is installed via native installer or specify a valid path with options.pathToClaudeCodeExecutable.

Generated by manaflow preview system

@cmux-agent

cmux-agent Bot commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
Older manaflow preview screenshots (latest comment is below)

Preview Videos and Screenshots

Open Workspace (1 hr expiry) · Open Dev Browser (1 hr expiry) · Open Diff Heatmap

Failed to capture screenshots for commit 79b3405.

Claude Code native binary not found at /root/.bun/bin/claude. Please ensure Claude Code is installed via native installer or specify a valid path with options.pathToClaudeCodeExecutable.

Generated by manaflow preview system

@cmux-agent

cmux-agent Bot commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
Older manaflow preview screenshots (latest comment is below)

Preview Videos and Screenshots

Open Workspace (1 hr expiry) · Open Dev Browser (1 hr expiry) · Open Diff Heatmap

Failed to capture screenshots for commit d1bcb17.

Claude Code native binary not found at /root/.bun/bin/claude. Please ensure Claude Code is installed via native installer or specify a valid path with options.pathToClaudeCodeExecutable.

Generated by manaflow preview system

@cmux-agent

cmux-agent Bot commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
Older manaflow preview screenshots (latest comment is below)

Preview Videos and Screenshots

Open Workspace (1 hr expiry) · Open Dev Browser (1 hr expiry) · Open Diff Heatmap

Failed to capture screenshots for commit 3ffceb7.

Claude Code native binary not found at /root/.bun/bin/claude. Please ensure Claude Code is installed via native installer or specify a valid path with options.pathToClaudeCodeExecutable.

Generated by manaflow preview system

@cmux-agent

cmux-agent Bot commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
Older manaflow preview screenshots (latest comment is below)

Preview Videos and Screenshots

Open Workspace (1 hr expiry) · Open Dev Browser (1 hr expiry) · Open Diff Heatmap

Failed to capture screenshots for commit 6133da0.

Claude Code native binary not found at /root/.bun/bin/claude. Please ensure Claude Code is installed via native installer or specify a valid path with options.pathToClaudeCodeExecutable.

Generated by manaflow preview system

@cmux-agent

cmux-agent Bot commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
Older manaflow preview screenshots (latest comment is below)

Preview Videos and Screenshots

Open Workspace (1 hr expiry) · Open Dev Browser (1 hr expiry) · Open Diff Heatmap

Failed to capture screenshots for commit 834e156.

Claude Code native binary not found at /root/.bun/bin/claude. Please ensure Claude Code is installed via native installer or specify a valid path with options.pathToClaudeCodeExecutable.

Generated by manaflow preview system

@cmux-agent

cmux-agent Bot commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Preview Videos and Screenshots

Open Workspace (1 hr expiry) · Open Dev Browser (1 hr expiry) · Open Diff Heatmap

Failed to capture screenshots for commit c9cafc0.

Claude Code native binary not found at /root/.bun/bin/claude. Please ensure Claude Code is installed via native installer or specify a valid path with options.pathToClaudeCodeExecutable.

Generated by manaflow preview system

@lawrencecchen

lawrencecchen commented Feb 20, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@lawrencecchen
lawrencecchen merged commit ea05934 into main Feb 20, 2026
5 checks passed
@lawrencecchen
lawrencecchen deleted the issue-180-http-nonsecure-hosts branch February 20, 2026 23:39
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Feb 20, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c9cafc0806

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/Panels/BrowserPanel.swift
Comment thread cmuxTests/UpdatePillReleaseVisibilityTests.swift
@lawrencecchen lawrencecchen mentioned this pull request Feb 21, 2026
Merged
@lawrencecchen

lawrencecchen commented Feb 21, 2026

Copy link
Copy Markdown
Contributor Author

Follow-up fixes for the unresolved Codex review threads are in #240.

Addressed threads:

bn-l pushed a commit to bn-l/cmux that referenced this pull request Apr 3, 2026
@lawrencecchen
Merge pull request manaflow-ai#206 from manaflow-ai/issue-180-http-no…
4808e86 
…nsecure-hosts

Allow HTTP in built-in browser for local dev hosts
@teamleaderleo teamleaderleo mentioned this pull request Sep 30, 2026
Closed
4 tasks done

This branch was successfully deployed

1 active deployment
Preview — c9cafc08 Deployed Feb 20, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't access non-secure connections in web browser

1 participant

@lawrencecchen