Skip to content

Fix Cmd+Enter being routed as browser reload in browser surfaces - #213

Merged
austinywang merged 1 commit into
mainfrom
cmux/cmd-enter-bug
Feb 20, 2026
Merged

Fix Cmd+Enter being routed as browser reload in browser surfaces#213
austinywang merged 1 commit into
mainfrom
cmux/cmd-enter-bug

Conversation

@austinywang

@austinywang austinywang commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • stop routing Cmd+Return/Enter from CmuxWebView.performKeyEquivalent through app/menu shortcuts
  • gate omnibar Return submit so only plain/Shift Return submits (not Cmd/Ctrl/Option modified Return)
  • add regression tests for both WebView key-equivalent routing and omnibar Return submit policy

Fixes #144

Testing

  • xcodebuild -project GhosttyTabs.xcodeproj -scheme cmux-unit -configuration Debug -destination 'platform=macOS' -only-testing:cmuxTests/CmuxWebViewKeyEquivalentTests -only-testing:cmuxTests/BrowserOmnibarReturnSubmitPolicyTests test
  • ./scripts/reload.sh --tag fix-cmd-enter-browser
  • xcodebuild -project GhosttyTabs.xcodeproj -scheme cmux -configuration Debug -destination 'platform=macOS' build

@cmux-agent

cmux-agent Bot commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Preview Videos and Screenshots

Open Workspace (1 hr expiry) · Open Dev Browser (1 hr expiry) · Open Diff Heatmap

Failed to capture screenshots for commit d1fb1db.

Claude Code native binary not found at /root/.bun/bin/claude. Please ensure Claude Code is installed via native installer or specify a valid path with options.pathToClaudeCodeExecutable.

Generated by manaflow preview system

@vercel

vercel Bot commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cmux Ready Ready Preview, Comment Feb 20, 2026 11:19pm

@austinywang
austinywang merged commit 270115c into main Feb 20, 2026
6 of 7 checks passed
bn-l pushed a commit to bn-l/cmux that referenced this pull request Apr 3, 2026
@austinywang
Fix Cmd+Enter being routed as browser reload (manaflow-ai#213)
453f739
@cubic-dev-ai cubic-dev-ai Bot mentioned this pull request Sep 2, 2026
Closed

This branch was successfully deployed

1 active deployment
Preview — d1fb1db1 Deployed Feb 20, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cmd + Enter refreshes browser (bug)

1 participant

@austinywang