Repository navigation
Follow up: resolve surface.read_text workspace targeting - #220
Merged
Merged
Conversation
Addresses review feedback from #219 by resolving read-screen targets against requested workspace/surface instead of the selected workspace.
Contributor
Preview Videos and ScreenshotsOpen Workspace (1 hr expiry) · Open Dev Browser (1 hr expiry) · Open Diff Heatmap Failed to capture screenshots for commit
Generated by manaflow preview system |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bn-l
pushed a commit
to bn-l/cmux
that referenced
this pull request
Apr 3, 2026
…eview-comments Follow up: resolve surface.read_text workspace targeting
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
surface.read_textso it resolves reads against the requestedworkspace_id/surface_idinstead of the currently selected workspaceread_screenbehavior unchanged for v1 while sharing the terminal text extraction pathtests_v2/test_read_screen_capture_pane_parity.pyto verify reads from a non-selected workspace (v2 and CLI)Context
Validation
xcodebuild -project GhosttyTabs.xcodeproj -scheme cmux -configuration Debug -destination 'platform=macOS' buildCMUX_TAG=followup-pr-219-comments CMUX_SOCKET=/tmp/cmux-debug-followup-pr-219-comments.sock CMUX_SOCKET_PATH=/tmp/cmux-debug-followup-pr-219-comments.sock CMUXTERM_CLI=/tmp/cmux-followup-pr-219-comments/Build/Products/Debug/cmux python3 tests_v2/test_read_screen_capture_pane_parity.pyCMUX_TAG=followup-pr-219-comments CMUX_SOCKET=/tmp/cmux-debug-followup-pr-219-comments.sock CMUX_SOCKET_PATH=/tmp/cmux-debug-followup-pr-219-comments.sock CMUXTERM_CLI=/tmp/cmux-followup-pr-219-comments/Build/Products/Debug/cmux python3 tests/test_blank_screen.py