Repository navigation
Remove border below titlebar - #242
Conversation
Remove the 1px separator line overlay at the bottom of the custom titlebar and its associated fakeTitlebarSeparatorColor computed property.
Older manaflow preview screenshots (latest comment is below)Preview Videos and ScreenshotsOpen Workspace (1 hr expiry) · Open Dev Browser (1 hr expiry) · Open Diff Heatmap Failed to capture screenshots for commit
Generated by manaflow preview system |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Older manaflow preview screenshots (latest comment is below)Preview Videos and ScreenshotsOpen Workspace (1 hr expiry) · Open Dev Browser (1 hr expiry) · Open Diff Heatmap Failed to capture screenshots for commit
Generated by manaflow preview system |
Update bonsplit submodule to remove the background fill on hovered non-selected tabs.
Older manaflow preview screenshots (latest comment is below)Preview Videos and ScreenshotsOpen Workspace (1 hr expiry) · Open Dev Browser (1 hr expiry) · Open Diff Heatmap Failed to capture screenshots for commit
Generated by manaflow preview system |
…tabs, browser theme bg - Add back 1px bottom border on titlebar using NSColor.separatorColor (matches bonsplit tab separator color) - Tab hover background now applies to all tabs including the selected one - Browser address bar and under-page background now use Ghostty theme background color instead of window background
Preview Videos and ScreenshotsOpen Workspace (1 hr expiry) · Open Dev Browser (1 hr expiry) · Open Diff Heatmap Failed to capture screenshots for commit
Generated by manaflow preview system |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4755913de6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Match the empty-page background to the terminal theme so newly-created browsers | ||
| // don't flash white before content loads. | ||
| webView.underPageBackgroundColor = .windowBackgroundColor | ||
| webView.underPageBackgroundColor = GhosttyApp.shared.defaultBackgroundColor |
There was a problem hiding this comment.
Refresh WKWebView under-page color on theme updates
GhosttyApp.shared.defaultBackgroundColor is mutable at runtime (it is updated when Ghostty config/background changes), but this assignment snapshots it only once during panel initialization. As a result, already-open browser panels keep the old under-page color after a theme/background change, so blank/loading pages can flash with stale coloring until the panel is recreated. Please hook this to the existing background-change notification path and reapply underPageBackgroundColor.
Useful? React with 👍 / 👎.
| .overlay(alignment: .bottom) { | ||
| Rectangle() | ||
| .fill(fakeTitlebarSeparatorColor) | ||
| .fill(Color(nsColor: .separatorColor)) | ||
| .frame(height: 1) |
There was a problem hiding this comment.
Remove the titlebar separator instead of recoloring it
This change still renders a 1px rectangle at the bottom of the custom titlebar, so the border remains present in all themes; only its color source changed. If the intent of this commit is to remove the border below the titlebar, the overlay needs to be removed rather than kept with separatorColor.
Useful? React with 👍 / 👎.
* Remove border below titlebar Remove the 1px separator line overlay at the bottom of the custom titlebar and its associated fakeTitlebarSeparatorColor computed property. * Remove tab hover background in bonsplit Update bonsplit submodule to remove the background fill on hovered non-selected tabs. * Restore titlebar border with system separator color, hover bg on all tabs, browser theme bg - Add back 1px bottom border on titlebar using NSColor.separatorColor (matches bonsplit tab separator color) - Tab hover background now applies to all tabs including the selected one - Browser address bar and under-page background now use Ghostty theme background color instead of window background
Bump the ghostty submodule from b1a49b601 to 257a40956, the merge of manaflow-ai/ghostty#252. That PR adds the offscreen embedded platform (GHOSTTY_PLATFORM_OFFSCREEN = 6, CPU frame and Linux dmabuf callbacks, app-thread draw) behind -Dembedded-offscreen, so the cross-platform GPUI and cmux-browser clients can render daemon terminals offscreen on Linux and Windows from the same fork. The default macOS GhosttyKit build does not change, and cmux-next does not use the new platform. feat-cmux-next now tracks fork main (coordinator decision), so the bump also brings the fork-main merges between the old pin and the #252 base dcb1d6965: #242 (PTY tee after the parser, under the renderer mutex), #243, #245, #247, #250 (prompt line and replay fixes), #246, #248, #249 (VT replay blank cells keep the default style) and #251 (config API window padding, whose fix commit was the old pin). scripts/ghosttykit-checksums.txt pins the published 257a409 GhosttyKit archive (build-ghosttykit.yml run 36989929300), which every cmux-next CI job downloads. docs/ghostty-fork.md documents the offscreen platform, #242 and a map of every merge in the range, with conflict notes. The cmux main pin's local-only binding flag (324c02738) is not on fork main; cmux-next does not use it.
Summary
fakeTitlebarSeparatorColorcomputed propertyTest plan