Repository navigation
Localize settings search aliases for all locales - #3296
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
Greptile SummaryThis PR adds search alias localizations for 17 new locales (ar, bs, da, de, es, fr, it, ko, nb, pl, pt-BR, ru, th, tr, uk, zh-Hans, zh-Hant) across all 87 settings alias keys, and also normalizes the existing en/ja indentation from 6-space to 4-space. The change is mechanically complete and consistent across all keys and locales with one minor exception noted below. Confidence Score: 4/5Safe to merge; the change is a pure localization addition with no logic changes and the one found issue is a minor search alias quality gap. Only P2 findings: the "sign in out" vs "sign in sign out" inconsistency in all non-en/non-ja section.account aliases is a search quality edge case (the synonym "logout" still covers the intent), not a runtime error or data loss. All 1,653 new string entries carry state "translated" and all 87 keys × 19 locales are covered. Resources/Localizable.xcstrings — specifically the settings.search.alias.section.account value for the 17 new locales Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User types search query] --> B[SettingsSearchAliasIndex]
B --> C{Locale}
C -->|en / ja| D["section.account alias:\n'…sign in sign out email…'"]
C -->|ar, bs, da, de, es, fr,\nit, ko, nb, pl, pt-BR,\nru, th, tr, uk, zh-Hans, zh-Hant| E["section.account alias:\n'…sign in out email…'\n⚠️ 'sign out' phrase missing"]
D --> F[Tokenize alias string]
E --> F
F --> G[Match against query tokens]
G --> H[Return matching settings sections]
Reviews (1): Last reviewed commit: "Localize settings search aliases for all..." | Re-trigger Greptile |
Follow-up to https://github.com/manaflow-ai/cmux/pull/3294.\n\nAdds settings search alias localizations for every locale currently present in the string catalog and Xcode project locale set, including ar, bs, da, de, es, fr, it, ko, nb, pl, pt-BR, ru, th, tr, uk, zh-Hans, and zh-Hant. English config/search tokens remain in each locale so users can search by settings.json keys too.\n\nVerification:\n- /Applications/Xcode.app/Contents/Developer/usr/bin/xcstringstool compile --dry-run --output-directory /tmp/cmux-searchalias-all-locales-xcstrings Resources/Localizable.xcstrings\n- alias key coverage script: 87 alias keys, 19 locales, 0 missing, 0 empty\n- git diff --check\n- xcodebuild -project GhosttyTabs.xcodeproj -scheme cmux-unit -destination 'platform=macOS' -derivedDataPath /tmp/cmux-searchalias-all-locales-unit -only-testing:cmuxTests/SettingsSearchIndexTests test\n- ./scripts/reload.sh --tag aliasloc
Summary by cubic
Localized settings search aliases for all locales to improve settings search. English
settings.jsonkeys still work in every locale, and the "sign out" alias phrase is preserved.Written for commit 3d9c054. Summary will update on new commits. Review in cubic