Skip to content

Fix browser deeplink handling for custom URL schemes - #392

Merged
austinywang merged 1 commit into
mainfrom
cmux/347
Feb 23, 2026
Merged

austinywang merged 1 commit into
mainfrom
cmux/347

Conversation

@austinywang

@austinywang austinywang commented Feb 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • detect non-embedded URL schemes in browser navigation and hand them off to macOS via NSWorkspace.shared.open(...)
  • apply the same external handoff for createWebViewWith flows (target=_blank / window.open)
  • add regression tests for external-vs-embedded scheme classification

Testing

  • xcodebuild -project GhosttyTabs.xcodeproj -scheme cmux-unit -configuration Debug -destination 'platform=macOS' -only-testing:cmuxTests/BrowserExternalNavigationSchemeTests test
  • xcodebuild -project GhosttyTabs.xcodeproj -scheme cmux -configuration Debug -destination 'platform=macOS' build
  • ./scripts/reload.sh --tag fix-custom-url-schemes

Closes #347

@vercel

vercel Bot commented Feb 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cmux Ready Ready Preview, Comment Feb 23, 2026 6:48pm

@austinywang
austinywang merged commit d42126a into main Feb 23, 2026
5 checks passed
bn-l pushed a commit to bn-l/cmux that referenced this pull request Apr 3, 2026

This branch was successfully deployed

1 active deployment
Preview — 1a79a8ae Deployed Feb 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Safari: custom URL schemes (deeplinks) fail with "unsupported URL"

1 participant