Fix ripgrep resolution for Nix installs - #3946

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
cmux	Ready	Preview, Comment	May 19, 2026 8:07am
cmux-staging	Building	Preview, Comment	May 19, 2026 8:07am

❌ Failed checks (1 warning, 1 inconclusive)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Greptile Summary

This PR fixes ripgrep discovery for Nix installs by replacing two independent ad-hoc resolver functions (in FileSearchController and SessionIndexStore) with a single shared RipgrepExecutableResolver that respects a new user-configurable automation.ripgrepBinaryPath setting and adds common Nix profile locations to the default search list.

• RipgrepExecutableResolver follows a four-level precedence: configured path (with ~ expansion) → macOS defaults → Nix profile paths → PATH. A non-empty configured path that fails the executable check returns .configuredPathNotExecutable instead of silently falling through, so Find surfaces a localized String(format:)-substituted error and session search emits a unified-log warning before falling back to the Foundation scan.
• Settings plumbing is fully wired: cmux.schema.json, the JSON-path allowlist, the settings template, the managed import, Settings → Automation UI (with localized label/subtitle/placeholder), the search index, and search aliases all include the new automation.ripgrepBinaryPath key.
• Localization is complete across all three supported locales (en, ja, ko) for every new user-facing string, including the %@ format-specifier error key consumed by String(format:).

Confidence Score: 5/5

Safe to merge — the resolver is well-isolated, all three locales are covered, the configuredPathNotExecutable path is surfaced correctly in both Find and session search, and the previous review issues are fully addressed.

The change consolidates two previously divergent resolver implementations into a single, dependency-injectable RipgrepExecutableResolver. The session search path changed from a one-time static-let to per-call resolution, which is intentional (settings changes take effect immediately) and the overhead is trivial (stat calls). Localization, JSON schema, managed import, allowlist, search index, and settings UI are all updated in lockstep. Seven new resolver unit tests and one settings-import integration test cover all meaningful code paths. No blocking primitives, no actor-isolation regressions, no sensitive data in logs.

No files require special attention.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Search triggered\nFind or Session] --> B[RipgrepExecutableResolver.resolution]
    B --> C{configuredPath\nnon-empty?}
    C -- Yes --> D{isExecutable\nconfiguredPath?}
    D -- Yes --> E[.found — use configured binary]
    D -- No --> F[.configuredPathNotExecutable]
    F --> G{Caller?}
    G -- FileSearchController --> H[Emit localized error\nin Find UI]
    G -- SessionIndexStore --> I[os_log warning\nfall back to Foundation scan]
    C -- No --> J[Check default paths\n/opt/homebrew, /usr/local,\n/opt/local, /usr/bin,\nNix profile paths ×5]
    J --> K{Any path\nexecutable?}
    K -- Yes --> E
    K -- No --> L[Walk PATH entries]
    L --> M{rg found\nin PATH?}
    M -- Yes --> E
    M -- No --> N[.notFound]
    N --> O{Caller?}
    O -- FileSearchController --> P[Emit rg-not-installed\nerror in Find UI]
    O -- SessionIndexStore --> Q[Fall back to\nFoundation substring scan]

_{Reviews (13): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile}