Repository navigation
Conversation
…ts' Babel plugin The react-native-worklets Babel plugin emits __workletHash as a number and omits __closure for worklets that capture no variables. These were treated as regular JS functions and threw "Regular javascript function '...' cannot be shared" when called from another worklet. Fixes margelo#275 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Babel plugin from
react-native-worklets(Reanimated 4) emits__workletHashas a number and omits__closurefor worklets that capture no variables. worklets-core only accepts a worklet when the hash is a string or__closureexists, so these worklets were treated as regular JS functions and threwRegular javascript function '...' cannot be sharedwhen called from another worklet.Fixes #275
Changes
JsiWorklet::isClosurelessWorklet(): returns true when__workletHashis a number and__initData.codeis a string.isDecoratedAsWorklet(): accept closureless worklets.createWorklet(): when__closureis missing on a closureless worklet, use an empty array instead of bailing out. Generated code for such worklets never readsthis.__closure.Existing worklets (string hash, or any worklet with a
__closure) take the same path as before.Test plan
'worklet'function with no captured variables, called from a worklet on a worklets-core context, runs instead of throwing.react-native-worklets-core/pluginalone still work.🤖 Generated with Claude Code