Repository navigation
Fix table/list parsing ambiguity - #767
Merged
Merged
Conversation
|
This actually introduces a regression for everybody who was writing their table without leading pipes. See here for example. Is this change really necessary? If there's a parsing ambiguity, then this ambiguity still exists after this change, and the only difference is that it broke a lot of existing Markdown documents. |
Member
|
@laurent22 answered in laurent22/joplin#7858 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix parsing of
a | b - | - 1 | 2Markdown-it parses it as a table, but it should not be one, because there is a list on the second line that intercepts the table.
The GFM spec says:
Also GitHub's own parser parses this as a list, not a table.