feat(android.FavoritesView): Display toast when first time on favorites & has old pinned routes #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaylaBrady
commented
Jul 30, 2025
| modifier = Modifier.fillMaxWidth().height(IntrinsicSize.Min), | ||
| horizontalAlignment = Alignment.CenterHorizontally, | ||
| verticalArrangement = Arrangement.spacedBy(32.dp), | ||
| verticalArrangement = Arrangement.spacedBy(10.dp), |
Collaborator
Author
There was a problem hiding this comment.
Decreasing the spacing here b/c otherwise the toast blocks the "Add stops" button. Confirmed this change with design.
KaylaBrady
commented
Jul 30, 2025
| assertEquals(analyticsLogged, Pair("favorites_count", "1")) | ||
| } | ||
|
|
||
| @Test |
Collaborator
Author
There was a problem hiding this comment.
unrelated change: This test wasn't being run, and needed a little fixing to pass (UUIDs weren't matching up, causing it to fail)
boringcactus
approved these changes
Jul 30, 2025
b9d4408 to
1df9c12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: 🤖 | Favorites | Toast on first time only
What is this PR for?
iOS
android
- [] Expensive calculations are run inwithContext(Dispatchers.Default)where possible (ideally in shared code)Testing
What testing have you done?
Screen_Recording_20250730_150558_One.UI.Home.2.mp4