Remove MCDeferred: MCDeferred<MCStack> programState; -> MCStack *programState; - #105
Open
gc00 wants to merge 2 commits into
Open
Remove MCDeferred: MCDeferred<MCStack> programState; -> MCStack *programState;#105gc00 wants to merge 2 commits into
gc00 wants to merge 2 commits into
Conversation
gc00
marked this pull request as draft
May 17, 2024 20:25
gc00
marked this pull request as ready for review
May 18, 2024 17:58
Collaborator
Author
|
@maxwellpirtle , When I test this code, I'm not seeing a bug. I know that you've seen a bug. |
Collaborator
Running results in a bug. In the trace printout (when I ran it was trace 23) we see e.g. Thread 1 appears twice |
gc00
force-pushed
the
remove-MCDeferred
branch
2 times, most recently
from
July 15, 2024 13:44
b609f73 to
ccd1d91
Compare
Collaborator
Author
|
With the latest commits from other PRs, this PR now seems to work. |
* This used to be: MCDeferred<MCStack> programState; * MCDeferred is not used anywhere else. (A comment there was: "This clever workaround ..." But as others say: "Beware of clever code.")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCDeferred<MCStack> programState;MCDeferredis not used anywhere else.(A comment there was: "This clever workaround ..." But as others say: "Beware of clever code.")
In the future, we need to make
programStatea true singleton class: