Skip to content

Revert "Merge pull request #103 from jczimskey/fix/pr-view-deprecation" - #104

Merged
LangLangBart merged 2 commits into
mainfrom
revert_103
Apr 8, 2026
Merged

Revert "Merge pull request #103 from jczimskey/fix/pr-view-deprecation"#104
LangLangBart merged 2 commits into
mainfrom
revert_103

Conversation

@LangLangBart

@LangLangBart LangLangBart commented Apr 8, 2026

Copy link
Copy Markdown
Collaborator

This reverts commit 3c621f0, reversing
changes made to 556df2e.

@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown

sh-checker report

To get the full details, please check in the job output.

shellcheck errors 
'shellcheck ' found no issues.
shfmt errors 

'shfmt --simplify --indent 4 --case-indent' returned error 1 finding the following formatting issues:

----------
diff gh-notify.orig gh-notify
--- gh-notify.orig
+++ gh-notify
@@ -448,24 +448,24 @@
         Issue)
             local fields="number,title,state,author,createdAt,body,url,assignees,labels,milestone,comments"
             local template
-            template="{{- \$last := \"\" -}}
-{{- range .comments -}}{{- \$last = . -}}{{- end -}}
-{{- if \$last -}}
-{{ \"Latest Comment\" | autocolor \"magenta\" }} • {{ \$last.author.login | autocolor \"bold\" }} • {{ timeago \$last.createdAt }}
-{{ \$last.body }}
-
-{{ \"────────────────────────────────────────────────────────────────────────────────\" | autocolor \"gray\" }}
+            template='{{- $last := "" -}}
+{{- range .comments -}}{{- $last = . -}}{{- end -}}
+{{- if $last -}}
+{{ "Latest Comment" | autocolor "magenta" }} • {{ $last.author.login | autocolor "bold" }} • {{ timeago $last.createdAt }}
+{{ $last.body }}
+
+{{ "────────────────────────────────────────────────────────────────────────────────" | autocolor "gray" }}
 
 {{ end -}}
-{{printf \"#%v\" .number | autocolor \"green\"}} {{.title | autocolor \"bold\"}}
-{{.state | autocolor \"bold\"}} • {{.author.login | autocolor \"bold\"}} opened {{timeago .createdAt}}
+{{printf "#%v" .number | autocolor "green"}} {{.title | autocolor "bold"}}
+{{.state | autocolor "bold"}} • {{.author.login | autocolor "bold"}} opened {{timeago .createdAt}}
 {{if .assignees}}Assignees: {{range .assignees}}{{.login}} {{end}}
 {{end}}{{if .milestone}}Milestone: {{.milestone.title}}
 {{end}}{{if .labels}}Labels: {{range .labels}}{{.name}} {{end}}
 {{end}}
-{{.body}}"
-
-            if [[ -n "${all_comments:-}" ]]; then
+{{.body}}'
+
+            if [[ -n ${all_comments:-} ]]; then
                 template+=$'\n\n{{range .comments}}\n---\n{{.author.login | autocolor "bold"}} • {{timeago .createdAt}}\n{{.body}}\n{{end}}'
             fi
             command gh issue view "$number" --repo "$repo_full_name" --json "$fields" --template "$template"
@@ -473,16 +473,16 @@
         PullRequest)
             local fields="number,title,state,author,createdAt,baseRefName,headRefName,body,url,reviewDecision,assignees,labels,milestone"
             local template
-            template="{{printf \"#%v\" .number | autocolor \"green\"}} {{.title | autocolor \"bold\"}}
-{{.state | autocolor \"bold\"}} • {{.author.login | autocolor \"bold\"}} wants to merge into {{.baseRefName | autocolor \"cyan\"}} from {{.headRefName | autocolor \"cyan\"}} • {{timeago .createdAt}}
+            template='{{printf "#%v" .number | autocolor "green"}} {{.title | autocolor "bold"}}
+{{.state | autocolor "bold"}} • {{.author.login | autocolor "bold"}} wants to merge into {{.baseRefName | autocolor "cyan"}} from {{.headRefName | autocolor "cyan"}} • {{timeago .createdAt}}
 {{if .reviewDecision}}Reviewers: {{.reviewDecision}}
 {{end}}{{if .assignees}}Assignees: {{range .assignees}}{{.login}} {{end}}
 {{end}}{{if .milestone}}Milestone: {{.milestone.title}}
 {{end}}{{if .labels}}Labels: {{range .labels}}{{.name}} {{end}}
 {{end}}
-{{.body}}"
-
-            if [[ -n "${all_comments:-}" ]]; then
+{{.body}}'
+
+            if [[ -n ${all_comments:-} ]]; then
                 fields+=",comments"
                 template+=$'\n\n{{range .comments}}\n---\n{{.author.login | autocolor "bold"}} • {{timeago .createdAt}}\n{{.body}}\n{{end}}'
             fi
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt --simplify --indent 4 --case-indent -w filename

1 similar comment
@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown

sh-checker report

To get the full details, please check in the job output.

shellcheck errors 
'shellcheck ' found no issues.
shfmt errors 

'shfmt --simplify --indent 4 --case-indent' returned error 1 finding the following formatting issues:

----------
diff gh-notify.orig gh-notify
--- gh-notify.orig
+++ gh-notify
@@ -448,24 +448,24 @@
         Issue)
             local fields="number,title,state,author,createdAt,body,url,assignees,labels,milestone,comments"
             local template
-            template="{{- \$last := \"\" -}}
-{{- range .comments -}}{{- \$last = . -}}{{- end -}}
-{{- if \$last -}}
-{{ \"Latest Comment\" | autocolor \"magenta\" }} • {{ \$last.author.login | autocolor \"bold\" }} • {{ timeago \$last.createdAt }}
-{{ \$last.body }}
-
-{{ \"────────────────────────────────────────────────────────────────────────────────\" | autocolor \"gray\" }}
+            template='{{- $last := "" -}}
+{{- range .comments -}}{{- $last = . -}}{{- end -}}
+{{- if $last -}}
+{{ "Latest Comment" | autocolor "magenta" }} • {{ $last.author.login | autocolor "bold" }} • {{ timeago $last.createdAt }}
+{{ $last.body }}
+
+{{ "────────────────────────────────────────────────────────────────────────────────" | autocolor "gray" }}
 
 {{ end -}}
-{{printf \"#%v\" .number | autocolor \"green\"}} {{.title | autocolor \"bold\"}}
-{{.state | autocolor \"bold\"}} • {{.author.login | autocolor \"bold\"}} opened {{timeago .createdAt}}
+{{printf "#%v" .number | autocolor "green"}} {{.title | autocolor "bold"}}
+{{.state | autocolor "bold"}} • {{.author.login | autocolor "bold"}} opened {{timeago .createdAt}}
 {{if .assignees}}Assignees: {{range .assignees}}{{.login}} {{end}}
 {{end}}{{if .milestone}}Milestone: {{.milestone.title}}
 {{end}}{{if .labels}}Labels: {{range .labels}}{{.name}} {{end}}
 {{end}}
-{{.body}}"
-
-            if [[ -n "${all_comments:-}" ]]; then
+{{.body}}'
+
+            if [[ -n ${all_comments:-} ]]; then
                 template+=$'\n\n{{range .comments}}\n---\n{{.author.login | autocolor "bold"}} • {{timeago .createdAt}}\n{{.body}}\n{{end}}'
             fi
             command gh issue view "$number" --repo "$repo_full_name" --json "$fields" --template "$template"
@@ -473,16 +473,16 @@
         PullRequest)
             local fields="number,title,state,author,createdAt,baseRefName,headRefName,body,url,reviewDecision,assignees,labels,milestone"
             local template
-            template="{{printf \"#%v\" .number | autocolor \"green\"}} {{.title | autocolor \"bold\"}}
-{{.state | autocolor \"bold\"}} • {{.author.login | autocolor \"bold\"}} wants to merge into {{.baseRefName | autocolor \"cyan\"}} from {{.headRefName | autocolor \"cyan\"}} • {{timeago .createdAt}}
+            template='{{printf "#%v" .number | autocolor "green"}} {{.title | autocolor "bold"}}
+{{.state | autocolor "bold"}} • {{.author.login | autocolor "bold"}} wants to merge into {{.baseRefName | autocolor "cyan"}} from {{.headRefName | autocolor "cyan"}} • {{timeago .createdAt}}
 {{if .reviewDecision}}Reviewers: {{.reviewDecision}}
 {{end}}{{if .assignees}}Assignees: {{range .assignees}}{{.login}} {{end}}
 {{end}}{{if .milestone}}Milestone: {{.milestone.title}}
 {{end}}{{if .labels}}Labels: {{range .labels}}{{.name}} {{end}}
 {{end}}
-{{.body}}"
-
-            if [[ -n "${all_comments:-}" ]]; then
+{{.body}}'
+
+            if [[ -n ${all_comments:-} ]]; then
                 fields+=",comments"
                 template+=$'\n\n{{range .comments}}\n---\n{{.author.login | autocolor "bold"}} • {{timeago .createdAt}}\n{{.body}}\n{{end}}'
             fi
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt --simplify --indent 4 --case-indent -w filename

@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown

sh-checker report

To get the full details, please check in the job output.

shellcheck errors 
'shellcheck ' found no issues.
shfmt errors 

'shfmt --simplify --indent 4 --case-indent' returned error 1 finding the following formatting issues:

----------
diff gh-notify.orig gh-notify
--- gh-notify.orig
+++ gh-notify
@@ -448,24 +448,24 @@
         Issue)
             local fields="number,title,state,author,createdAt,body,url,assignees,labels,milestone,comments"
             local template
-            template="{{- \$last := \"\" -}}
-{{- range .comments -}}{{- \$last = . -}}{{- end -}}
-{{- if \$last -}}
-{{ \"Latest Comment\" | autocolor \"magenta\" }} • {{ \$last.author.login | autocolor \"bold\" }} • {{ timeago \$last.createdAt }}
-{{ \$last.body }}
-
-{{ \"────────────────────────────────────────────────────────────────────────────────\" | autocolor \"gray\" }}
+            template='{{- $last := "" -}}
+{{- range .comments -}}{{- $last = . -}}{{- end -}}
+{{- if $last -}}
+{{ "Latest Comment" | autocolor "magenta" }} • {{ $last.author.login | autocolor "bold" }} • {{ timeago $last.createdAt }}
+{{ $last.body }}
+
+{{ "────────────────────────────────────────────────────────────────────────────────" | autocolor "gray" }}
 
 {{ end -}}
-{{printf \"#%v\" .number | autocolor \"green\"}} {{.title | autocolor \"bold\"}}
-{{.state | autocolor \"bold\"}} • {{.author.login | autocolor \"bold\"}} opened {{timeago .createdAt}}
+{{printf "#%v" .number | autocolor "green"}} {{.title | autocolor "bold"}}
+{{.state | autocolor "bold"}} • {{.author.login | autocolor "bold"}} opened {{timeago .createdAt}}
 {{if .assignees}}Assignees: {{range .assignees}}{{.login}} {{end}}
 {{end}}{{if .milestone}}Milestone: {{.milestone.title}}
 {{end}}{{if .labels}}Labels: {{range .labels}}{{.name}} {{end}}
 {{end}}
-{{.body}}"
-
-            if [[ -n "${all_comments:-}" ]]; then
+{{.body}}'
+
+            if [[ -n ${all_comments:-} ]]; then
                 template+=$'\n\n{{range .comments}}\n---\n{{.author.login | autocolor "bold"}} • {{timeago .createdAt}}\n{{.body}}\n{{end}}'
             fi
             command gh issue view "$number" --repo "$repo_full_name" --json "$fields" --template "$template"
@@ -473,16 +473,16 @@
         PullRequest)
             local fields="number,title,state,author,createdAt,baseRefName,headRefName,body,url,reviewDecision,assignees,labels,milestone"
             local template
-            template="{{printf \"#%v\" .number | autocolor \"green\"}} {{.title | autocolor \"bold\"}}
-{{.state | autocolor \"bold\"}} • {{.author.login | autocolor \"bold\"}} wants to merge into {{.baseRefName | autocolor \"cyan\"}} from {{.headRefName | autocolor \"cyan\"}} • {{timeago .createdAt}}
+            template='{{printf "#%v" .number | autocolor "green"}} {{.title | autocolor "bold"}}
+{{.state | autocolor "bold"}} • {{.author.login | autocolor "bold"}} wants to merge into {{.baseRefName | autocolor "cyan"}} from {{.headRefName | autocolor "cyan"}} • {{timeago .createdAt}}
 {{if .reviewDecision}}Reviewers: {{.reviewDecision}}
 {{end}}{{if .assignees}}Assignees: {{range .assignees}}{{.login}} {{end}}
 {{end}}{{if .milestone}}Milestone: {{.milestone.title}}
 {{end}}{{if .labels}}Labels: {{range .labels}}{{.name}} {{end}}
 {{end}}
-{{.body}}"
-
-            if [[ -n "${all_comments:-}" ]]; then
+{{.body}}'
+
+            if [[ -n ${all_comments:-} ]]; then
                 fields+=",comments"
                 template+=$'\n\n{{range .comments}}\n---\n{{.author.login | autocolor "bold"}} • {{timeago .createdAt}}\n{{.body}}\n{{end}}'
             fi
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt --simplify --indent 4 --case-indent -w filename

@LangLangBart
LangLangBart merged commit dff4634 into main Apr 8, 2026
1 check failed
@LangLangBart
LangLangBart deleted the revert_103 branch April 8, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@LangLangBart