Repository navigation
Conversation
With setDisablePausedPriority(true), insertOrUpdate() maps a PAUSED priority to urgency 7, incremental, so the stream stays schedulable. updateIfExist() did not apply that mapping: updating an enqueued stream to PAUSED erased it from the queue, as if the setting were off. Apply the same mapping in updateIfExist() and add a test next to the existing Paused test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #479.
With
setDisablePausedPriority(true),insertOrUpdate()maps a PAUSED priority to urgency 7, incremental, so the stream stays schedulable.updateIfExist()did not apply that mapping. Updating an enqueued stream to PAUSED erased it from the queue, as if the setting were off. The mapping was moved into the queue in fe61493, and onlyinsertOrUpdate()got it.This change applies the same mapping at the top of
updateIfExist(). With the setting off, behaviour is unchanged: the existingPausedtest still passes.Testing
HTTPPriorityQueueTest.PausedWithDisablePausedPriority, next toPaused. With the setting on, it checks thatinsertOrUpdate(PAUSED)andupdateIfExist(PAUSED)(from a sequential and from an incremental priority) all leave the stream queued at(7, incremental).main@ 88184e0 the new test fails:contains(id)is false afterupdateIfExist. With this change,ctest -R '^(RoundRobin|PriorityQueue|HTTPPriorityQueue)'passes 48/48, andctest -R "PausedPriority|QuicStreamManagerTest.*Priorit"passes 6/6, includingQuicPacketSchedulerTest.PausedPriorityDisabled.getdeps.py build mvfst) with GCC 13.3 on x86_64 Linux, RelWithDebInfo. Thenninja PriorityQueueTest QuicPacketSchedulerTest QuicStreamManagerTest. The full test suite, proxygen, clang, macOS and Windows were not run.clang-format --dry-run -Werror(20.1.8,quic/.clang-format) is clean on both changed files.main@ 813bc6c. Neither touched file changed upstream in between, so the tests were not re-run after the rebase.This change was drafted with Claude Code (claude-opus-5-5); the test results above are from the runs described.