test: increase timeout for heartbeat test to end #347
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that it may take more than `2 * HEARTBEAT_INTERVAL` to finish a full cycle of heartbeat messages. This commit increases timeout for the test to finish to `3 * HEARTBEAT_INTERVAL`.
Member
Author
|
@belochub ping. |
belochub
approved these changes
Jul 18, 2018
belochub
pushed a commit
that referenced
this pull request
Jul 18, 2018
It appears that it may take more than `2 * HEARTBEAT_INTERVAL` to finish a full cycle of heartbeat messages. This commit increases timeout for the test to finish to `3 * HEARTBEAT_INTERVAL`. PR-URL: #347 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Member
|
Landed in ffea298. |
belochub
pushed a commit
that referenced
this pull request
Aug 30, 2018
It appears that it may take more than `2 * HEARTBEAT_INTERVAL` to finish a full cycle of heartbeat messages. This commit increases timeout for the test to finish to `3 * HEARTBEAT_INTERVAL`. PR-URL: #347 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that it may take more than
2 * HEARTBEAT_INTERVALto finish a full cycle of heartbeat messages. This commit increases timeout for the test to finish to3 * HEARTBEAT_INTERVAL.