-
Notifications
You must be signed in to change notification settings - Fork 12
v2.0.0 proposal #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
v2.0.0 proposal #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #323 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
PR-URL: #332 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
PR-URL: #332 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
PR-URL: #335 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
PR-URL: #342 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
PR-URL: #343 Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Fix reconnection throwing when the error during the process also led to the `close` event being emitted on the `connection` object. PR-URL: #345 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Fix incorrect usage of asynchronous sessionStorageProviders by the server. PR-URL: #346 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
It appears that it may take more than `2 * HEARTBEAT_INTERVAL` to finish a full cycle of heartbeat messages. This commit increases timeout for the test to finish to `3 * HEARTBEAT_INTERVAL`. PR-URL: #347 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
PR-URL: #351 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
PR_URL: #352 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Callbacks passed to jstp method calls will now return an error when the connection is being closed. Since it is known, that callback messages are not being resent on connection drop, a special method on Connection was added that resends call message on connection to the server, and thus can be used for making a call to idempotent methods on the server. PR-URL: #320 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Co-authored-by: Dmytro Nechai <nechaido@gmail.com>
Also fix all linter errors due to new `implicit-arrow-linebreak` rule. PR-URL: #353 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
* Use UMD both for pre-packaged browser bundle and for usage with module bundlers * Update webpack to 4.x PR-URL: #355 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Remove end-of-life Node.js 9 and add the current Node.js 10. PR-URL: #356 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
PR-URL: #358 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Add a missing regression test for connectAndInspect with empty array of interfaces. PR-URL: #359 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
PR-URL: #362 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
PR-URL: #360 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
PR-URL: #364 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
PR-URL: #365 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
PR-URL: #363 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com> Reviewed-By: Timur Shemsedinov <timur.shemsedinov@gmail.com>
Due to the callbacks receiving error `ERR_CALLBACK_LOST` being called synchronously during session restoration, calls with resending were being resent twice: first time at the moment of such callback call (leading to saving the call message into the session's buffer) and second time immediately after the procedure of the session restoration while resending all of the buffered messages (that by that moment include unwanted call messages). PR-URL: #369 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
PR-URL: #370 Reviewed-By: Denys Otrishko <shishugi@gmail.com>
PR-URL: #367 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
* Rely on a built-in reconnector. * Add possibility to specify verboseness level. PR-URL: #366 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Update eslint-config-metarhia to v4.0.0 and fix all of the linting errors. PR-URL: #371 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
PR-URL: #372 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
PR-URL: #373 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
PR-URL: #374 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
c3f2621 to
b24fb34
Compare
Next major release of the package marks the addition of built-in reconnection functionality, using UMD for browser bundle, support for asynchronous SessionStorageProviders, support for custom logging on client-side and support for custom authentication errors. CLI was also updated to support some of the features above. Reconnection is enabled by default and uses the binary exponential backoff algorithm; this is considered a breaking change. The other breaking change is decoupling of the parser and serializer into the separate package: https://github.com/metarhia/mdsf. This means that methods `parse()`, `stringify()` and `parseNetworkMessages()` are no longer available as part of the jstp package. Starting with this release `metarhia-jstp` is being moved into the @metarhia organization on npm, the new name of the package is `@metarhia/jstp`. Notable changes: * lib: add support for async SessionStorageProvider (Mykola Bilochub) * lib: realize reconnection by transport replacement (Mykola Bilochub) * server: enable returning errors from authPolicy (Igor Gorodetskyy) * lib: add utility for call messages resending (Mykola Bilochub) * connection: enable custom logging on client (Mykola Bilochub) * build: use UMD for browser bundle (Alexey Orlenko) * lib,build: use Web Crypto API in browser (Mykola Bilochub) * serde: remove serde implementation and use mdsf (Mykola Bilochub) * cli: use new jstp features (Dmytro Nechai)
b24fb34 to
018e69f
Compare
nechaido
approved these changes
Aug 31, 2018
aqrln
approved these changes
Aug 31, 2018
lundibundi
approved these changes
Aug 31, 2018
belochub
added a commit
that referenced
this pull request
Sep 3, 2018
Next major release of the package marks the addition of built-in reconnection functionality, using UMD for browser bundle, support for asynchronous SessionStorageProviders, support for custom logging on client-side and support for custom authentication errors. CLI was also updated to support some of the features above. Reconnection is enabled by default and uses the binary exponential backoff algorithm; this is considered a breaking change. The other breaking change is decoupling of the parser and serializer into the separate package: https://github.com/metarhia/mdsf. This means that methods `parse()`, `stringify()` and `parseNetworkMessages()` are no longer available as part of the jstp package. Starting with this release `metarhia-jstp` is being moved into the @metarhia organization on npm, the new name of the package is `@metarhia/jstp`. Notable changes: * lib: add support for async SessionStorageProvider (Mykola Bilochub) * lib: realize reconnection by transport replacement (Mykola Bilochub) * server: enable returning errors from authPolicy (Igor Gorodetskyy) * lib: add utility for call messages resending (Mykola Bilochub) * connection: enable custom logging on client (Mykola Bilochub) * build: use UMD for browser bundle (Alexey Orlenko) * lib,build: use Web Crypto API in browser (Mykola Bilochub) * serde: remove serde implementation and use mdsf (Mykola Bilochub) * cli: use new jstp features (Dmytro Nechai) PR-URL: #375 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next major release of the package marks the addition of built-in reconnection
functionality, using UMD for browser bundle, support for asynchronous
SessionStorageProviders, support for custom logging on client-side and support
for custom authentication errors. CLI was also updated to support some of the
features above. Reconnection is enabled by default and uses the binary
exponential backoff algorithm; this is considered a breaking change.
One of the breaking changes is decoupling of the parser and serializer into the
separate package: https://github.com/metarhia/mdsf. This means that methods
parse(),stringify()andparseNetworkMessages()are no longer availableas part of the jstp package.
Starting with this release
metarhia-jstpis being moved into the @metarhiaorganization on npm, the new name of the package is
@metarhia/jstp.Notable changes:
All changes: