build: use UMD for browser bundle #355
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqrln
commented
Aug 3, 2018
| net: false, | ||
| tls: false, | ||
| // TODO: support WebCrypto API in lib/common.js and uncomment this | ||
| // crypto: 'empty', |
Member
Author
There was a problem hiding this comment.
This will both reduce the browser build size, like, three times, and also improve performance.
belochub
reviewed
Aug 4, 2018
package.json
Outdated
| "./dist/cjs/lib/socket.js": false, | ||
| "./dist/cjs/lib/wss.js": false, | ||
| "./dist/cjs/lib/ws.js": "./dist/cjs/lib/ws-browser.js", | ||
| "./dist/cjs/lib/simple-auth-policy.js": false |
Member
There was a problem hiding this comment.
I think we can also add:
"./dist/cjs/lib/simple-session-storage-provider.js": false
since it can only be used on server side.
Member
|
I've rebased the branch on |
belochub
approved these changes
Aug 6, 2018
* Use UMD both for pre-packaged browser bundle and for usage with module bundlers * Update webpack to 4.x
belochub
pushed a commit
that referenced
this pull request
Aug 6, 2018
* Use UMD both for pre-packaged browser bundle and for usage with module bundlers * Update webpack to 4.x PR-URL: #355 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Member
|
Landed in 0ccd28d. |
belochub
pushed a commit
that referenced
this pull request
Aug 30, 2018
* Use UMD both for pre-packaged browser bundle and for usage with module bundlers * Update webpack to 4.x PR-URL: #355 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish and export CommonJS modules transpiled with Babel for usagewith module bundlers