Repository navigation
chat: remove unused mcpServerByTool map from tools picker - #334230
유민호 (yoominho91) wants to merge 1 commit into
Conversation
The map has had no reader since tool sets were introduced in microsoft#249448; the picker now resolves MCP buckets through ToolDataSource.toKey. Claude-Session: https://claude.ai/code/session_01B8NGgDp1aqKyL2KMwMzWAv
There was a problem hiding this comment.
🟢 Approval recommended
The redundant code is safely removed with no unresolved issues.
Pull request overview
Removes unused MCP server lookup work from the chat tools picker.
Changes:
- Removes the unused
mcpServerByToolmap and population loops. - Removes the now-unused
IMcpServerimport.
File summaries
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/actions/chatToolPicker.ts |
Eliminates unused MCP lookup logic while retaining active MCP service usage. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Friendly ping — this is a small cleanup: |
|
Closing this to keep my open PR count down — it has been sitting well past this repo's usual review turnaround with no maintainer feedback, and I would rather not leave unsolicited changes cluttering the queue. The change is self-contained (removes a map that is written but never read) and still applies; happy to reopen if a maintainer wants to take a look. |
…#79) All three were pinged on 2026-09-12 and had no human review at all — every reaction on them came from bots. Closed on 2026-09-15 with the same short note used for earlier withdrawals, following the Ghost precedent of reclaiming the slot rather than leaving unsolicited changes in someone's queue. - nrwl/nx#36633 — 34 days open - typeorm/typeorm#12746 — 46 days open - microsoft/vscode#334230 — 12 days open Open 7 -> 4, closed 17 -> 20. Merges unchanged at 14. Claude-Session: https://claude.ai/code/session_01ABuXgtVFhvgie5kXCPcBja Co-authored-by: irontaek <13810291+irontaek@users.noreply.github.com>
Details
showToolsPickerbuilds amcpServerByToolmap (tool id →IMcpServer) on every invocation, but nothing reads it.The last reader was removed in #249448 ("Add support for tool sets", 2025-05-21): the old
mcpServerByTool.get(tool.id)lookup inchatToolActions.tswas replaced by keying buckets throughToolDataSource.toKey(source), and the map was left behind. #249556 then moved the picker intochatToolPicker.tswith the map still unused, and it survived the QuickTree rewrite (#257748) and the removal of the old Quick Pick picker (#260414).Change
mcpService.servers.get()/server.tools.get()that filled it.IMcpServerimport.mcpServiceis still used further down to build themcpServersmap for bucket actions, so that stays.How to test
No behavior change: the picker never read from this map, so the rendered items, enablement, and MCP bucket actions are unaffected.
npm run eslint,npm run hygiene, andtsc --noEmitpass locally on the touched file.Disclosure
This was found with a static check for collections that are written but never read; the history above and the change were verified by hand. An LLM-based assistant was used to help draft this PR.
https://claude.ai/code/session_01B8NGgDp1aqKyL2KMwMzWAv