Tags: microsoft/vstest
Tags
[rel/18.9] Remove dead DotNet-VSTS-Infra-Access variable group refere… …nce (#16357) Backport of fdd72c5 (PR #16203) from main. The DotNet-VSTS-Infra-Access variable group only contained the dn-bot-devdiv-drop-r-code-r PAT, which has been migrated to WIF (service connection dnceng-devdiv-drop-rw-code-rw-wif). The group is expired/de-authorized, and because it was referenced at the root variables level it was resolved at YAML compile time, causing the pipeline to fail to load entirely from rel/18.9. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Fix protocol negotiation timeout when STJ reflection is disabled (18.… …8.1) (#16281) * Set an explicit reflection-based TypeInfoResolver on the STJ options Test projects that set JsonSerializerIsReflectionEnabledByDefault=false put that switch into their runtimeconfig.json, which testhost runs under. With TypeInfoResolver left null, System.Text.Json falls back to the implicit default resolver that the switch disables, so testhost throws while deserializing the first protocol message and dies, and the runner waits out the whole connection timeout and reports "Failed to negotiate protocol, waiting for response timed out". Assigning an explicit DefaultJsonTypeInfoResolver keeps reflection-based serialization working regardless of the switch. This is the minimal servicing fix for 18.8.1, main and rel/18.9 already resolve this as part of the larger NativeAOT work in #16045. Also bump VersionPrefix to 18.8.1. Fixes #16274. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Re-trigger CI (flaky RunSettingsManager singleton test on ubuntu leg) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Remove dead DotNet-VSTS-Infra-Access variable group reference (#16203) ( #16269) The DotNet-VSTS-Infra-Access variable group (VG 4 in dnceng/internal) only contained the dn-bot-devdiv-drop-r-code-r PAT which has been migrated to WIF. The PAT is expired and disabled. The variable group reference is no longer needed since DevDiv drop access token is now acquired via WIF service connection. (cherry picked from commit fdd72c5) Co-authored-by: Missy Messa <47990216+missymessa@users.noreply.github.com>
[rel/18.7] Skip nupkg verifier in .NET product build mode (#16092) The binding redirect verifier in verify-nupkgs.ps1 fails in the dotnet/dotnet VMR build because source-built dependency packages have older AssemblyVersion stamps than NuGet.org packages (e.g. System.Runtime.CompilerServices.Unsafe ships as 6.0.0.0 from source-build but 6.0.3.0 from NuGet.org). The newVersion of a bindingRedirect must equal the AssemblyVersion of the DLL actually shipped beside the exe, so no single value can satisfy both the VMR/source-build pipeline (dnceng-public) and the internal pipeline (dnceng / NuGet.org-based) at the same time. Back-port the same skip already present on rel/18.8 and main: gate the _VerifyNuGetPackages target on DotNetBuild != 'true' so the VMR no longer runs the verifier, while the internal pipeline (which produces the actually- shipped packages) continues to validate the redirects. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove DiagnosticSource binding redirect (rel/18.6) (#15776) * Remove DiagnosticSource binding redirect from app.configs The binding redirect for System.Diagnostics.DiagnosticSource (8.0.0.1) was added in #15567 but the DLL is excluded from the CLI package during packaging. The redirect points to a version that doesn't ship, causing MissingMethodException on net462 with DisableAppDomain=true when a test triggers assembly resolution for DiagnosticSource. Fixes #15765 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * [fix] Harden binding redirect validation to catch missing DLLs (#15778) * Error on binding redirects pointing to missing DLLs Change verify-binding-redirects.ps1 to fail when a binding redirect references a DLL that isn't in the package layout. Previously this was silently skipped, which allowed #15765 — a redirect for DiagnosticSource 8.0.0.1 shipped in the config but the DLL was excluded from the package. The whole-package-missing case (VMR) is still a skip. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Remove stale DiagnosticSource and Encodings.Web redirects from vstest.console The hardened validation script caught two more orphaned binding redirects in vstest.console/app.config — both DLLs are explicitly excluded from the CLI package nuspec. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix review feedback: fail locally on missing-DLL errors - Missing-DLL errors now Write-Error instead of reporting success - CI message distinguishes version mismatches (auto-fixable) from missing-DLL errors (manual removal needed) - Addresses Copilot review comments on lines 133 and 138 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix em-dash encoding in verify-binding-redirects.ps1 Replace Unicode em-dash (U+2014) with ASCII hyphen in comments and strings. The em-dash gets corrupted to multi-byte garbage on CI's PowerShell, causing a parse error that breaks the entire validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Remove FileSystemGlobbing from allow-list It ships in the package, so allowing it would mask a future packaging regression. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PreviousNext