Skip to content

fix(esm): fix source maps in esm loader - #38584

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:esm_24_2
Dec 16, 2025
Merged

fix(esm): fix source maps in esm loader#38584
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:esm_24_2

Conversation

@pavelfeldman

@pavelfeldman Pavel Feldman (pavelfeldman) commented Dec 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #38578

@github-actions

This comment has been minimized.

Sign in to view
yury-s
Yury Semikhatsky (yury-s) approved these changes Dec 16, 2025
View reviewed changes
Comment thread packages/playwright/src/transform/transform.ts Outdated
Comment thread packages/playwright/src/transform/esmLoader.ts
@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit ad99461 into microsoft:main Dec 16, 2025
28 of 31 checks passed
@github-actions

github-actions Bot commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

4 failed
❌ [playwright-test] › playwright.artifacts.spec.ts:429 › should take screenshot when page is closed in afterEach @macos-latest-node20-1
❌ [playwright-test] › playwright.spec.ts:877 › page.pause() should disable test timeout @macos-latest-node20-1
❌ [playwright-test] › web-server.spec.ts:25 › should create a server @windows-latest-node20-2
❌ [playwright-test] › web-server.spec.ts:555 › should create multiple servers @windows-latest-node20-2

1 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1083 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`

34370 passed, 692 skipped

Merge workflow run.

@github-actions

github-actions Bot commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

Test results for "MCP"

9 failed
❌ [chromium] › mcp/console.spec.ts:74 › recent console messages @mcp-macos-15
❌ [chromium] › mcp/screenshot.spec.ts:22 › browser_take_screenshot (viewport) @mcp-macos-15
❌ [chromium] › mcp/screenshot.spec.ts:77 › --output-dir should work @mcp-macos-15
❌ [chromium] › mcp/screenshot.spec.ts:100 › browser_take_screenshot (type: png) @mcp-macos-15
❌ [chromium] › mcp/video.spec.ts:21 › should work with --save-video (isolated) @mcp-macos-15
❌ [chromium] › mcp/video.spec.ts:63 › should work with recordVideo (isolated) @mcp-macos-15
❌ [chromium] › mcp/video.spec.ts:21 › should work with --save-video (persistent) @mcp-macos-15
❌ [chromium] › mcp/video.spec.ts:63 › should work with recordVideo (persistent) @mcp-macos-15
❌ [webkit] › mcp/sse.spec.ts:208 › sse transport browser lifecycle (persistent, multiclient) @mcp-macos-15

2705 passed, 116 skipped

Merge workflow run.

Pavel Feldman (pavelfeldman) added a commit that referenced this pull request Dec 17, 2025
@pavelfeldman
cherry-pick(#38584): fix(esm): fix source maps in esm loader
a1d7364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yury-s Yury Semikhatsky (yury-s) yury-s approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Wrong line numbers in reports with type: module in package.json and Node.js 24.12.0

2 participants

@pavelfeldman @yury-s