Repository navigation
fix: sort and sort_by error on maps and arrays with undefined ordering - #2940
Open
johnhldiver-beep wants to merge 1 commit into
Open
johnhldiver-beep wants to merge 1 commit into
johnhldiver-beep wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2884.
Problem:
sortandsort_bysilently accept values with undefined ordering, whilemaxcorrectly errors. For example,yq -n '[{"a":1},{"a":0}] | sort'silently returned the input unsorted, and the same happened for arrays (map([.a]) | sort) and forsort_by(exp)when the expression evaluates to an array or object.Change:
sortandsort_bynow return a clear error when a comparison key is a map or array (or any value the comparison logic cannot order), matchingmaxbehavior. Ordering of numbers, strings, booleans, and nulls is unchanged. Tests: 4 new scenarios inoperator_sort_test.go.Verification:
go build ./...passes;TestSortByOperatorScenariospasses. Note:TestJSONScenariosfails on this branch and also on upstream master (pre-existing, Go-version-dependent JSON error wording), unrelated to this change.