Skip to content

Add PHPStan #64

Merged
JustSteveKing merged 2 commits into
minicli:mainfrom
WendellAdriel:php-stan-integration
May 5, 2023
Merged

Add PHPStan #64
JustSteveKing merged 2 commits into
minicli:mainfrom
WendellAdriel:php-stan-integration

Conversation

@WendellAdriel

Copy link
Copy Markdown
Member

Hey @erikaheidi I'm creating this PR for an initial configuration for PHPStan.
I added it and fixed the issues until Level 5 because starting on Level 6 there are some more issues to fix and I don't have the time to go over all of them now, but if this PR is merged I'll be working on other PRs to increase the level

@WendellAdriel

WendellAdriel commented May 4, 2023

Copy link
Copy Markdown
Member Author

Also, if this gets merged, I'll send another PR adding the PHPStan check to the GitHub Actions if you want to.
I also added the PHPStan check to the GitHub Actions

@JustSteveKing JustSteveKing merged commit f493c70 into minicli:main May 5, 2023
@JustSteveKing

Copy link
Copy Markdown
Collaborator

This was on my list of things to add!

@WendellAdriel WendellAdriel deleted the php-stan-integration branch May 5, 2023 15:01
@WendellAdriel

Copy link
Copy Markdown
Member Author

Nice, @JustSteveKing!
Thanks for merging it!
I’ll be working on new PRs to level up the PHPStan config! 😉

@JustSteveKing

Copy link
Copy Markdown
Collaborator

Nice, @JustSteveKing!
Thanks for merging it!
I’ll be working on new PRs to level up the PHPStan config! 😉

I am 100% up for this! I'd like to also introduce more generics if possible to make the experience of using Minicli feel more sleek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants