Static analysis - #68
Merged
Merged
Conversation
Collaborator
Author
|
@WendellAdriel here we go 🔥 |
Member
That's what I'm talking about!!! |
Closed
Member
|
@JustSteveKing In my PR I worked on the |
Collaborator
Author
That sounds like a great idea! |
Member
I'll do that, then. |
erikaheidi
approved these changes
May 9, 2023
Member
|
Great work, thank you! 👏🏼 👏🏼 👏🏼 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch ups the PHPStan level to level 9 🔥
I had to use two
@phpstan-ignore-next-lineon thefopenfunctions, as I cannot cast or guarantee anything is a resource without changing functionality too much. This is a compromise I am happy to make for now, until more reactors are planned.