Add ThemeStyle and ThemeConfig classes for wrapping themes style configuration#71
Merged
Conversation
Member
Author
|
If this gets merged, in a future major release we can update the return [
'default' => [ CLIColors::$FG_WHITE ],
'alt' => [ CLIColors::$FG_BLACK, CLIColors::$BG_WHITE ],
...
];return [
'default' => ThemeStyle::make(CLIColors::$FG_WHITE),
'alt' => ThemeStyle::make(CLIColors::$FG_BLACK, CLIColors::$BG_WHITE),
...
];We can also update it to return a return ThemeConfig::make([
'default' => ThemeStyle::make(CLIColors::$FG_WHITE),
'alt' => ThemeStyle::make(CLIColors::$FG_BLACK, CLIColors::$BG_WHITE),
...
]) |
erikaheidi
approved these changes
May 9, 2023
erikaheidi
left a comment
Member
There was a problem hiding this comment.
This is great 👍🏼 thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I'm adding a
ThemeStyleclass that will behave like a DTO for the theme style configuration.Currently, it's being used an array where the key
0is theforegroundstyle and1is thebackgroundstyle.The new class is to make things easier to understand and to have better visibility of how things work.
I also refactored some test cases to take advantage of some of the Pest features.
Since the methods
getStyleandsetStyleare being used only in theDefaultThemeand user-created themes extend theDefaultTheme, I think that this won't impact any user-created themes.This is also adding a
ThemeConfigclass that will be an object that will group the differentThemeStylefor each type of output of a theme and the addition of this class has the same purpose as theThemeStyleone.