This repository was archived by the owner on Apr 25, 2026. It is now read-only.
modernizes for loop in cmd/, internal/ - #21309
Merged
Merged
Conversation
Member
|
can you fix the PR title - what does this cleanup do etc? be a little more descriptive on the changes. |
Contributor
Author
updated title and description |
klauspost
reviewed
May 26, 2025
klauspost
left a comment
Contributor
There was a problem hiding this comment.
Did you check if any of these vars are updated during the loops?
Contributor
Author
yes, none of them do |
harshavardhana
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
codebase cleanup. modernizes for loop
Motivation and Context
modernize codebase for non-test files
How to test this PR?
functionality stays the same
Types of changes