Repository navigation
Fix help navigation in the options editor - #8428
Open
twelfthlabor wants to merge 1 commit into
Open
twelfthlabor wants to merge 1 commit into
twelfthlabor wants to merge 1 commit into
Conversation
twelfthlabor
force-pushed
the
research/options-editor-help-4578
branch
from
September 15, 2026 00:46
3d844e8 to
5498e1e
Compare
twelfthlabor
force-pushed
the
research/options-editor-help-4578
branch
from
October 11, 2026 13:56
5498e1e to
15b1e0d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pressing
?in the options editor now shows the right shortcuts. Closing help returns to the editor with pending changes intact.Fixes #2952.
Tested: the 16 new regression cases fail before the fix and pass after.
test/mitmproxy/tools/consolegives 74 passed with this change.test_integrationfails in my environment both on this branch and on main, so it is not caused by this change. Lint, mypy, and formatting pass. Rebased on current main. Full test suite not run.Checklist