Skip to content

test(insight): use junction for Windows node_modules link#705

Merged
mksglu merged 1 commit into
mksglu:nextfrom
NgoQuocViet2001:fix/ctx-insight-windows-cors-test
May 25, 2026
Merged

test(insight): use junction for Windows node_modules link#705
mksglu merged 1 commit into
mksglu:nextfrom
NgoQuocViet2001:fix/ctx-insight-windows-cors-test

Conversation

@NgoQuocViet2001

@NgoQuocViet2001 NgoQuocViet2001 commented May 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • use a Windows junction for the temporary node_modules link in the ctx-insight CORS test
  • keep the existing directory symlink behavior on non-Windows platforms

Problem

On normal Windows setups without Developer Mode/admin symlink privileges, the directory symlink used by the test harness can fail with EPERM, so the ctx-insight CORS test fails before the insight server starts.

Validation

  • pnpm exec vitest run tests/analytics/insight-cors.test.ts --reporter=dot
  • pnpm exec vitest run tests/core/server.test.ts -t 'ctx_insight|insight-cache' --reporter=dot
  • git diff --check

@mksglu
mksglu merged commit d7fa8ac into mksglu:next May 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants