Repository navigation
fix(ios): drop trailing slash from WebDriverAgent /source URL - #496
Merged
Merged
Conversation
Legacy iOS robot requested `/source/?format=json`. Current WebDriverAgent
(appium/WebDriverAgent master, runner build 16.14.x) does not route the
trailing-slash form and answers:
{"value":{"error":"unknown command","message":"Unhandled endpoint: /source/ ..."}}
The error object has no `children`, so `filterSourceElements` returned an
empty list and `mobile_list_elements_on_screen` reported zero elements on a
physical iPhone (iOS 26.6.2) while `/screenshot` and `/wda/screen` worked.
`/source?format=json` is the route WebDriverAgent registers and is accepted by
both older and current builds.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (1)
✨ Finishing Touches
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-signed copy of #488 by @dudnjsckrgo, so it can pass the signed-commits rule on
main. The commit is unchanged apart from the signature and a rebase onto currentmain; authorship stays with @dudnjsckrgo.Supersedes #488.