Repository navigation
feat: ship jellyfin-web 12.3 and reproduce Jellyfin 12.3 - #561
Merged
Merged
Conversation
…Jellyfin 12.3 does An addon's imdbRating of Infinity, inf or 1e999 became +Inf, which the JSON encoder then failed on: /Items answered 200 with an empty body. The metadata editor answered 500 to "NaN" or "Infinity". Jellyfin 12.3 no longer stores ratings or gains that are not finite numbers. Such a rating now counts as none, from an addon, an IPTV provider or the editor, which answers 204 and lets the field follow the addon again.
The web client is jellyfin-web 12.3, taken from the official Jellyfin 12.3 image pinned by digest, with its source archive. Polyfin reports 12.3.0, as Jellyfin 12.3 does on /System/Info and /System/Info/Public, and the admin app signs into jellyfin-web as 12.3.0. Responses recorded from a real Jellyfin 12.3 with the fixture scripts match 12.2's apart from noise, so the fixtures stay as recorded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jellyfin 12.3 shipped on October 23, server and jellyfin-web both bugfix releases. Polyfin now ships jellyfin-web 12.3 and answers as Jellyfin 12.3 does.
Pins
Dockerfiletakes jellyfin-web's built files fromjellyfin/jellyfin:12.3@sha256:2038fe038ab3876a80f6e7b7e0aef6607b032c7dc0c9b3ad3296d0b2eba3bbb5(the multi-platform index), and its source archivev12.3.tar.gzby its sha256. The same methods give the old 12.2 pins exactly.internal/jellyfin/jellyfin.goreports12.3.0, as a real Jellyfin 12.3 does on/System/Infoand/System/Info/Public. The admin app signs into jellyfin-web as 12.3.0.Each 12.3 change
Server:
imdbRatingofInfinity,infor1e999became +Inf, which the JSON encoder failed on:/Itemsanswered 200 with an empty body. The metadata editor answered 500 to"NaN"or"Infinity". Such a rating now counts as none, from an addon, an IPTV provider or the editor, which answers 204 as Jellyfin 12.3 does. Gains were already finite.0:1aspect ratio, which 12.3 reports as it is, a difference older than 12.3, now documented and tested.Web:
/MediaSegmentsonce per playback instead of twice.UserDataChangedmessages Polyfin sends every socket of the user. jellyfin-web's query keys and cache settings are unchanged, so the answers kept for the last user are still dropped when another one signs in.@jellyfin/sdk1.0.1) changes no request. Remove broken header links in suggestions view jellyfin/jellyfin-web#8684 and Show the library name as page title jellyfin/jellyfin-web#8537 need nothing.Against a real Jellyfin 12.3
scripts/jellyfin-fixtures.shand its music part were run against Jellyfin 12.2 and 12.3, with the same setup, together with the administration requests the scripts do not make: 12.3 answers exactly as 12.2, apart from trace IDs, dates, segment names and encoder output sizes, which a fresh 12.2 recording also changes. The fixtures stay as recorded;docs/development.mdsays so.Tests
TestRatingsThatAreNotFiniteNumbersAreNone: a fake addon rates titlesInfinity,NaN,1e999and-inf; the listing is readable JSON and only the title rated 7.5 has a rating; the editor answers 204 to those values and the field follows the addon again. It failed before: the listing had an empty body, and the editor answered 500.TestProviderRatingsAreNumbersOutOfTengainsNaN, which came back as"NaN"before.TestVideoWithoutFrameSizecovers a video stream without a width or height.Smoke
The image built from this branch serves jellyfin-web 12.3: its
main.jellyfin.bundle.jsis byte-identical to Jellyfin 12.3's. In Chrome, with fake addons, an IPTV source and a music folder, the following worked:No request answered 5xx; the four 401s came from the sessions ended on purpose. The full suite passes.