Repository navigation
[misc] Add 'ss' relative time key to typescript definition - #4246
Merged
Merged
Conversation
Contributor
|
This is the same as #4138 but slightly better, maybe :) |
Contributor
Author
|
Hi ichernev! Is there anything that I need to address in the PR for it to be accepted? Thanks, xkxx |
Contributor
|
|
Contributor
Author
|
Hi @ichernev, How's the PR looking now? (Please ignore the git author screwup earlier :/) |
Contributor
Author
|
Hello @ichernev again, Could you take a look at this PR and see if there's anything else for it to be merged? Thanks, xkxx |
Contributor
Author
|
Hello, just a friendly ping if anyone would like to take another look at the PR :) |
Contributor
|
I think this looks good -- tagging for inclusion in the next release. |
This was referenced Dec 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
This patch adds 'ss' to RelativeTimeKey to make the typescript definition more complete, and updates the typing tests to match.
First patch to moment.js, so please let me know if there's anything I'm missing or if you have any suggestions for improvements!