Skip to content

Fix months parsing for stranger locales - #2869

Closed
ichernev wants to merge 3 commits into
moment:developfrom
ichernev:per-locale-month-regex
Closed

ichernev wants to merge 3 commits into
moment:developfrom
ichernev:per-locale-month-regex

Conversation

@ichernev

@ichernev ichernev commented Jan 6, 2016

Copy link
Copy Markdown
Contributor

This fixes #2841

TODO:

  • add weekdays in the mix
  • test with months ending in dot and enable it there too
  • sort regex parts by reverse length
  • add tests specific to this feature
  • fix polish monthsParse hack

@ichernev ichernev added this to the 2.11.1 milestone Jan 9, 2016
@ichernev

ichernev commented Jan 9, 2016

Copy link
Copy Markdown
Contributor Author

This got out of hand. I'll merge it because it does fix gd locale without breaking everything else. But a proper fix is still to come.

@zakhenry

zakhenry commented Jan 9, 2016

Copy link
Copy Markdown

@ichernev will this merge allow 2.11.1 to be tagged?

@ichernev

ichernev commented Jan 9, 2016

Copy link
Copy Markdown
Contributor Author

@xiphiaz I'll merge, tag and everything very soon.

@ichernev

ichernev commented Jan 9, 2016

Copy link
Copy Markdown
Contributor Author

Merged in cd03dae

@ichernev ichernev closed this Jan 9, 2016
ichernev added a commit that referenced this pull request Jan 9, 2016
Fix months parsing for stranger locales
@mattjohnsonpint

Copy link
Copy Markdown
Contributor

@ichernev - Are all 5 of the checkboxes at the top of this completed, or just the one?

@ichernev

Copy link
Copy Markdown
Contributor Author

@mj1856 only one. I completely forgot about this one. I'm re-doing #2782 using this code (completing the TODO list :)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parsing bug for MMM

3 participants