Repository navigation
Conversation
This update to Brian Schemp's patch calculates the current week once instead of twice for a small performance boost.
Member
|
Heads up. Because we came under JS Foundation management, we need a CLA signed for this to be merged. Should be just a couple clicks. |
Author
|
I completed the CLA here earlier today. https://js.foundation/CLA/ |
Author
|
Apparently I used the wrong from last time. CLA issue is now resolved. |
Contributor
|
Still displays yellow for me. |
Member
Author
|
@schempy could you sign the Contributor License Agreement by following this link? https://cla.js.foundation/moment/moment?pullRequest=3515 |
Contributor
|
@markstos I signed the CLA. |
Contributor
|
@schempy thank you! |
Contributor
|
Merged in 47cffae |
ichernev
added a commit
that referenced
this pull request
Nov 6, 2016
[feature] Fix #2300: Default to current week.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to Pull Request #3406 which adds one improvement:
It updates Brian Schemp's patch calculates the current week once
instead of twice for a small performance boost.