Repository navigation
Conversation
ichernev
force-pushed
the
fix-locale-race
branch
from
October 29, 2016 14:10
2349e5c to
4efb82e
Compare
ichernev
force-pushed
the
fix-locale-race
branch
from
October 29, 2016 14:11
4efb82e to
72918f8
Compare
Contributor
|
That's great, thank for fixing this! |
Contributor
Author
|
Merged in e107f50 |
ichernev
added a commit
that referenced
this pull request
Nov 6, 2016
[bugfix] Implement lazy-loading of child locales with missing prents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimalistic redo of #3336 without the crazy test scaffolding.
@skfd what do you think.
I'd wait and see if users are happy, there are a few ways to improve it, but if that works I'm happy to leave it.