Ensure mapParallelOrdered runs in parallel#846
Merged
Avasil merged 1 commit intoMar 21, 2019
Conversation
Contributor
Author
|
The build is failing with 1 failed test: I can't see how this is related to the change I made. I've also seen this test failing on other branches (eg https://travis-ci.org/monix/monix/jobs/504177945), so I think the test is flakey |
Avasil
approved these changes
Mar 21, 2019
Collaborator
|
I'll merge it, would be nice to add test for it so I'll leave #841 open Thank you once again :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #841
Is there a guarantee with the waiting for the semaphore permit that there will not be multiple permits blocked at once? If so, the ordering might not be guaranteed with this approach.