Fix race in MapParallelOrderedObservable#906
Merged
Merged
Conversation
Collaborator
|
Thank you! I wish we could add regression test but it would probably take about a minute so probably not worth it. |
Avasil
approved these changes
Jun 19, 2019
mdedetrich
pushed a commit
to mdedetrich/monix
that referenced
this pull request
Mar 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MapParallelOrderedObservablecould be stuck forever.Consider the following scenario:
whileloop insendDownstreamOrderedasqueueis empty, butsendDownstreamLockis being still lockedAcomes from upstream and is enqueued toqueueA's future is completed, and thensendDownstreamOrderedis invokedsendDownstreamLockis still locked, so the second call ofsendDownstreamOrderedcaused byAis rejectedsendDownstreamLockis finally unlockedsendDownstreamOrderedagainThis can likely happen especially for small tasks (such tasks are not suitable for this operator in the first place, though). For example, I can reproduce it with the following simple observable:
This patch will ensure that the polling of the queue is done as many as the number of elements.
As far as I have examined, there is no notable performance regression.
I'm not sure but #846 may have made the problem more likely.