Conversation
krkk
force-pushed
the
smooth-theme-change
branch
2 times, most recently
from
August 14, 2026 18:53
94bca41 to
cc5393d
Compare
Somehow, changing the image contents instead of the name of the image makes changing themes almost instant now. So much so the shield gets changed instantly, while the rest of the map goes a smooth transition. D:
krkk
force-pushed
the
smooth-theme-change
branch
from
August 14, 2026 19:27
cc5393d to
1fb5d84
Compare
krkk
marked this pull request as ready for review
August 14, 2026 19:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to fix a regression from #1395. That PR reverted the temporary VersaTiles map styles, which by doing so introduced some artefacts when changing themes.
Maplibregl seems to struggle with smooth transitions when fill-color is an expression (related?: mapbox/mapbox-gl-js#3170. different project, but it's a pre-fork issue and I couldn't find similar issue in the maplibre repo)