Skip to content

Ignore collapsed selections after pointer release - #22137

Open
calixteman wants to merge 1 commit into
mozilla:masterfrom
calixteman:issue22134
Open

calixteman wants to merge 1 commit into
mozilla:masterfrom
calixteman:issue22134

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

A delayed selectionchange can restore the selecting class after pointerup, blocking the next click on a form field.

Ignore collapsed ranges when no pointer is down. Keep non-collapsed ranges for Firefox selection caret drags, which can change the selection without pointerdown events.

It fixes #22134.

A delayed selectionchange can restore the selecting class after pointerup,
blocking the next click on a form field.

Ignore collapsed ranges when no pointer is down. Keep non-collapsed ranges
for Firefox selection caret drags, which can change the selection without
pointerdown events.

It fixes mozilla#22134.
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 11, 2026
@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

Commit 1a30040 (build logs).

Viewer Build Preview
Modern (gulp generic) ✅ viewer.html
Legacy (gulp generic-legacy) ✅ viewer.html

Previews are removed when the PR closes and may be pruned after 30 days without an update.

@codecov-commenter

codecov-commenter commented Oct 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (da95557) to head (1a30040).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #22137   +/-   ##
=======================================
  Coverage   90.30%   90.30%           
=======================================
  Files         277      277           
  Lines       67949    67951    +2     
=======================================
+ Hits        61360    61364    +4     
+ Misses       6589     6587    -2     
Flag Coverage Δ
browsertest 66.21% <0.00%> (-0.01%) ⬇️
integrationtest 69.35% <100.00%> (+0.07%) ⬆️
unittest 60.20% <0.00%> (+<0.01%) ⬆️
unittestcli 58.29% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: After a click on the page background, the first click on a form field goes to the text layer instead of the field

2 participants