osc.lua: ignore seek ranges without positive duration - #18349
Merged
sfan5 merged 1 commit intoAug 7, 2026
Merged
Conversation
guidocella
reviewed
Aug 7, 2026
seekRangesF() accepts a zero duration and produces NaN/Inf coordinates, which assdraw cannot format. Ignore seek-range metadata when the native duration property is unavailable or zero. Fixes mpv-player#18344
subotac
force-pushed
the
fix/osc-zero-duration-seek-ranges
branch
from
August 7, 2026 17:36
a56a5d5 to
3165c2a
Compare
guidocella
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seekRangesF()currently accepts a zero duration and produces NaN/Infcoordinates, which
assdrawcannot format. Restoree the positive-durationguard so invalid seek-range metadata is ignored
Tested with Lua 5.1 and 5.2 syntax checks and the full Lua lint suite.
Fixes #18344