Skip to content

fix: avoid retry count resets across batchMap redrives - #3661

Draft
vaibhavtiwari33 wants to merge 1 commit into
mainfrom
non-sink-retry-review
Draft

vaibhavtiwari33 wants to merge 1 commit into
mainfrom
non-sink-retry-review

Conversation

@vaibhavtiwari33

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Briefly describe the problem and the solution.

Related issues

Fixes #3603

Testing

How was this tested (unit/integration/manual)? Include commands, links, or screenshots if applicable.

Special notes for reviewers

Anything notable for review (risk, rollout, follow-ups).

Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
@codecov

codecov Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.98%. Comparing base (30010a9) to head (bcfc7fa).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/numaflow-core/src/mapper/map/batch.rs 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3661      +/-   ##
==========================================
+ Coverage   83.90%   83.98%   +0.08%     
==========================================
  Files         316      316              
  Lines       85964    85951      -13     
==========================================
+ Hits        72125    72183      +58     
+ Misses      13186    13112      -74     
- Partials      653      656       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build retry controller outside the UDF call

1 participant