Skip to content

Revert "Add uutils ln command" - #18605

Merged
fdncred merged 1 commit into
mainfrom
revert-18571-add-ln
Jul 14, 2026
Merged

fdncred merged 1 commit into
mainfrom
revert-18571-add-ln

Conversation

@fdncred

@fdncred fdncred commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Reverts #18571

@fdncred

fdncred commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

@dmatos2012 Can you please look into this. It appears to be an upstream problem where uucore doesn't always build so cached changes fail.

LnError formats via Fluent's translate! macro. On CI with a cargo cache, uucore’s build-time locale embedding often does not include ln, so Display falls back to bare ids:

• ln-error-same-file
• ln-failed-to-create-hard-link-dir
• ln-error-extra-operand
• …

Tests look for phrases like "same file" / "hard link not allowed for directory", so they fail.

That matches a stale uucore artifact: adding uu_ln doesn’t change uucore’s sources, so a cached uucore never re-runs its locale scan.

@dmatos2012

Copy link
Copy Markdown
Contributor

Yeah I had that same issue, and had to for some reason clean the cache and rebuilt. I assumed it was a "me" problem, but will see if I find a fix and push it upstream.

Thanks!

@fdncred
fdncred merged commit 2aea9fd into main Jul 14, 2026
16 checks passed
@fdncred
fdncred deleted the revert-18571-add-ln branch July 14, 2026 14:52
@github-actions github-actions Bot added this to the v0.115.0 milestone Jul 14, 2026
@fdncred fdncred added the notes:hide Noted only in "Full Changelog" section label Jul 14, 2026
@ofek

ofek commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Darn, I was looking forward to this. I don't quite understand something though: why didn't this upstream build issue manifest until now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

notes:hide Noted only in "Full Changelog" section

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants