Repository navigation
fix: canonicalize journey exit reasons - #1
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 550d960ecf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| enum class ENuxieJourneyExitReason : uint8 | ||
| { | ||
| Completed, | ||
| Dismissed, |
There was a problem hiding this comment.
Preserve existing enum ordinals when adding Dismissed
Adding Dismissed between existing ENuxieJourneyExitReason members shifts the underlying uint8 values for GoalMet, TriggerUnmatched, Expired, Error, and Cancelled. In Unreal, this enum is exposed as UENUM(BlueprintType) and used in a UPROPERTY, so previously serialized values (e.g., save data, replicated state, persisted Blueprint defaults) can be decoded as the wrong reason after upgrading. To avoid data corruption across versions, keep prior ordinals stable by appending new values or assigning explicit numeric constants.
Useful? React with 👍 / 👎.
Summary
Dismissedto the Unreal journey exit-reason enumTesting