Update wxPython to 4.3.1 - #20882

Link to issue number:

Closes #20700

Summary of the issue:

NVDA uses wxPython 4.2.4, which is based on wxWidgets 3.2.8.
wxPython 4.3 is the new release series, based on wxWidgets 3.3.

Description of user facing changes:

None intended.
wxWidgets 3.3 changes the default look of some controls, such as tree views.

Description of developer facing changes:

• wxPython is updated to 4.3.1, which is based on wxWidgets 3.3.3.
• wxWidgets 3.3 no longer provides the APIs that were deprecated in wxWidgets 3.0. wxPython 4.3 removes them as well. Add-ons that use them need to be updated.
• gui.nvdaControls.CustomCheckListBox.notifyIAccessible is removed.

Description of development approach:

• The wxPython pin in pyproject.toml is updated.
• Every wx name that NVDA's source code uses still exists in wxPython 4.3.1.
• wxWidgets 3.3.2 gives the check list box its own MSAA implementation. When an item is checked or unchecked, the check list box now sends a state change event itself. NVDA's CustomCheckListBox sent the same event from its check handler, in notifyIAccessible. Every toggle would be reported twice, so notifyIAccessible and its event binding are removed.
• CustomCheckListBox keeps its own accessible object, ListCtrlAccessible, which takes precedence over the one from wxWidgets. The wxWidgets 3.3.3 implementation reports no child items to MSAA. With it, object navigation cannot reach the list items and the position information (for example "1 of 3") is lost. It also reports every item as focused and no item as selected.
• The note on the Edge backend in gui.message.HtmlMessageDialog said that wxPython 4.3 would allow reusing one Edge WebView configuration. This is not the case. wxPython 4.3.1 does not expose a way to create an Edge configuration from Python. The note is corrected.

Testing strategy:

• Ran NVDA from source and tested the check lists in NVDA's settings, such as speech dictionaries, NVDA modifier keys and logging categories. Checking and unchecking an item is reported once. Object navigation reaches the list items. Position information is reported.
• Built a distribution. It contains the wxWidgets 3.3.3 libraries and the wxWidgets translations. The wxWidgets libraries are about 1 MB larger than before. The wxPython wheel now also ships libcairo-2.dll. The distribution does not include it, because wxWidgets only loads it on demand for its cairo renderer.
• To test manually:
  • Dialogs with radio buttons, such as the Elements List, configuration profiles and the speech dictionary dialog.
  • Tree views in the Elements List and the Input Gestures dialog.
  • Changing NVDA's language.
  • The width of the settings panels.

Known issues with pull request:

• The type stubs in wxPython 4.3.1 contain syntax errors. For example, wx/adv.pyi cannot be parsed. These are fixed in the upcoming wxPython release.
• The accessibility of the wxWidgets 3.3.3 check list box is not usable as is. NVDA keeps its own implementation for now.

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.